* [PATCH v1 1/1] i2c: designware-pci: clarify a comment for Merrifield
@ 2016-06-19 20:21 Andy Shevchenko
2016-06-20 6:47 ` Jarkko Nikula
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2016-06-19 20:21 UTC (permalink / raw)
To: Jarkko Nikula, Wolfram Sang, linux-i2c; +Cc: Andy Shevchenko
There are more than 7 busses, but only 7 are user visible. Update comment
accordingly.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/i2c/busses/i2c-designware-pcidrv.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
index b66c31a..7c5a340 100644
--- a/drivers/i2c/busses/i2c-designware-pcidrv.c
+++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
@@ -125,10 +125,10 @@ static int mfld_setup(struct pci_dev *pdev, struct dw_pci_controller *c)
static int mrfld_setup(struct pci_dev *pdev, struct dw_pci_controller *c)
{
/*
- * On Intel Merrifield the i2c busses are enumerated [1..7]. So, we add
- * 1 to shift the default range. Besides that the first PCI slot
- * provides 4 functions, that's why we have to add 0 to the head slot
- * and 4 to the tail one.
+ * On Intel Merrifield the user visible i2c busses are enumerated
+ * [1..7]. So, we add 1 to shift the default range. Besides that the
+ * first PCI slot provides 4 functions, that's why we have to add 0 to
+ * the fisrt slot and 4 to the next one.
*/
switch (PCI_SLOT(pdev->devfn)) {
case 8:
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1 1/1] i2c: designware-pci: clarify a comment for Merrifield
2016-06-19 20:21 [PATCH v1 1/1] i2c: designware-pci: clarify a comment for Merrifield Andy Shevchenko
@ 2016-06-20 6:47 ` Jarkko Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Nikula @ 2016-06-20 6:47 UTC (permalink / raw)
To: Andy Shevchenko, Wolfram Sang, linux-i2c
On 06/19/2016 11:21 PM, Andy Shevchenko wrote:
> There are more than 7 busses, but only 7 are user visible. Update comment
> accordingly.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/i2c/busses/i2c-designware-pcidrv.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
> index b66c31a..7c5a340 100644
> --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> @@ -125,10 +125,10 @@ static int mfld_setup(struct pci_dev *pdev, struct dw_pci_controller *c)
> static int mrfld_setup(struct pci_dev *pdev, struct dw_pci_controller *c)
> {
> /*
> - * On Intel Merrifield the i2c busses are enumerated [1..7]. So, we add
> - * 1 to shift the default range. Besides that the first PCI slot
> - * provides 4 functions, that's why we have to add 0 to the head slot
> - * and 4 to the tail one.
> + * On Intel Merrifield the user visible i2c busses are enumerated
> + * [1..7]. So, we add 1 to shift the default range. Besides that the
> + * first PCI slot provides 4 functions, that's why we have to add 0 to
> + * the fisrt slot and 4 to the next one.
typo -> ---^
Otherwise
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-20 6:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-19 20:21 [PATCH v1 1/1] i2c: designware-pci: clarify a comment for Merrifield Andy Shevchenko
2016-06-20 6:47 ` Jarkko Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).