linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: linux-i2c@vger.kernel.org
Cc: Wolfram Sang <wsa@the-dreams.de>
Subject: [PATCH 0/7] i2c: improve error messages when registering an adapter
Date: Sat,  9 Jul 2016 13:34:57 +0900	[thread overview]
Message-ID: <1468038904-2571-1-git-send-email-wsa@the-dreams.de> (raw)

The goal of this series is to have proper error messages whenever something in
i2c_add_adapter() and friends fail. Then, we can hereafter drop all similar
messages in drivers which is largely duplicated code and often not very helpful
because they are too generic.

To achieve this goal, we make sure that dev_* is used whenever a device is
available. pr_* is used when we have at least an adapter name. If not, we use
WARN to show the user the code path that failed. Error messages were added,
fixed, and made consistent. Also, the first patch fixes a potential leak found
while creating this series. Also, i2c_register_adapter() was a bit refactored
to be easier to handle. Please look at the patch descriptions for details. A
brach is here:

git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git strings/i2c

Looking forward to comments.

   Wolfram

Wolfram Sang (7):
  i2c: free idr when sanity checks in i2c_register_adapter() fail
  i2c: cleanup i2c_register_adapter() by refactoring recovery init
  i2c: improve error messages in i2c_register_adapter()
  i2c: add error message when obtaining idr fails
  i2c: print more info when of_i2c_notify fails
  i2c: print more info when acpi_i2c_space_handler() fails
  i2c: use pr_fmt in the core

 drivers/i2c/i2c-core.c | 124 ++++++++++++++++++++++++++-----------------------
 1 file changed, 66 insertions(+), 58 deletions(-)

-- 
2.8.1

             reply	other threads:[~2016-07-09  4:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-09  4:34 Wolfram Sang [this message]
2016-07-09  4:34 ` [PATCH 1/7] i2c: free idr when sanity checks in i2c_register_adapter() fail Wolfram Sang
2016-07-11 11:51   ` Jean Delvare
2016-07-09  4:34 ` [PATCH 2/7] i2c: cleanup i2c_register_adapter() by refactoring recovery init Wolfram Sang
2016-07-09  4:35 ` [PATCH 3/7] i2c: improve error messages in i2c_register_adapter() Wolfram Sang
2016-07-09  4:35 ` [PATCH 4/7] i2c: add error message when obtaining idr fails Wolfram Sang
2016-07-09  4:35 ` [PATCH 5/7] i2c: print more info when of_i2c_notify fails Wolfram Sang
2016-07-09  4:35 ` [PATCH 6/7] i2c: print more info when acpi_i2c_space_handler() fails Wolfram Sang
2016-07-09  8:11   ` Mika Westerberg
2016-07-09  4:35 ` [PATCH 7/7] i2c: use pr_fmt in the core Wolfram Sang
2016-07-14 12:47 ` [PATCH 0/7] i2c: improve error messages when registering an adapter Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468038904-2571-1-git-send-email-wsa@the-dreams.de \
    --to=wsa@the-dreams.de \
    --cc=linux-i2c@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).