From mboxrd@z Thu Jan 1 00:00:00 1970 From: Karl-Heinz Schneider Subject: Re: [PATCH v3 2/2] power: Adds support for Smart Battery System Manager Date: Tue, 19 Jul 2016 20:51:05 +0200 Message-ID: <1468954265.3053.3.camel@amnesix> References: <1bIiDr-0004G1-0P> <1468349295-4935-1-git-send-email-karl-heinz@schneider-inet.de> <1468349295-4935-3-git-send-email-karl-heinz@schneider-inet.de> <20160719041729.GC1640@katana> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from schneider-inet.de ([85.214.76.205]:48756 "EHLO h1714509.stratoserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751036AbcGSSvQ (ORCPT ); Tue, 19 Jul 2016 14:51:16 -0400 In-Reply-To: <20160719041729.GC1640@katana> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Wolfram Sang Cc: devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, linux-i2c@vger.kernel.org, Rob Herring , Mark Rutland , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , "Rafael J. Wysocki" , Peter Rosin , Phil Reid Hi Wolfram, Am Dienstag, den 19.07.2016, 06:17 +0200 schrieb Wolfram Sang: > > + data->muxc = i2c_mux_alloc(adapter, dev, SBSM_MAX_BATS, 0, > > + I2C_MUX_LOCKED, &sbsm_select, NULL); > > + if (!data->muxc) { > > + dev_err(dev, "failed to alloc i2c mux\n"); > > Don't print errors on ENOMEM. Will be fixed on next revision. > > Other than that, looks good to me, yet Peter has more insight to > i2c-muxes these days. > Tanks for review. Will wait another few days before sending a new revision, hence changes are rather small. -- Karl-Heinz