From: Daniel Wagner <wagi@monom.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Beniamino Galvani <b.galvani@gmail.com>,
Kamal Dasu <kdasu.kdev@gmail.com>, Ray Jui <rjui@broadcom.com>,
Tim Kryger <tim.kryger@linaro.org>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org,
Daniel Wagner <daniel.wagner@bmw-carit.de>
Subject: [PATCH v0 4/4] i2c: meson: Use complete() instead of complete_all()
Date: Wed, 3 Aug 2016 14:03:11 +0200 [thread overview]
Message-ID: <1470225791-16613-5-git-send-email-wagi@monom.org> (raw)
In-Reply-To: <1470225791-16613-1-git-send-email-wagi@monom.org>
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
There is only one waiter for the completion, therefore there
is no need to use complete_all(). Let's make that clear by
using complete() instead of complete_all().
The usage pattern of the completion is:
meson_i2c_xfer_msg()
reinit_completion()
...
/* Start the transfer */
...
wait_for_completion_timeout()
Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
---
drivers/i2c/busses/i2c-meson.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c
index 71d3929..76e2898 100644
--- a/drivers/i2c/busses/i2c-meson.c
+++ b/drivers/i2c/busses/i2c-meson.c
@@ -211,7 +211,7 @@ static void meson_i2c_stop(struct meson_i2c *i2c)
meson_i2c_add_token(i2c, TOKEN_STOP);
} else {
i2c->state = STATE_IDLE;
- complete_all(&i2c->done);
+ complete(&i2c->done);
}
}
@@ -238,7 +238,7 @@ static irqreturn_t meson_i2c_irq(int irqno, void *dev_id)
dev_dbg(i2c->dev, "error bit set\n");
i2c->error = -ENXIO;
i2c->state = STATE_IDLE;
- complete_all(&i2c->done);
+ complete(&i2c->done);
goto out;
}
@@ -269,7 +269,7 @@ static irqreturn_t meson_i2c_irq(int irqno, void *dev_id)
break;
case STATE_STOP:
i2c->state = STATE_IDLE;
- complete_all(&i2c->done);
+ complete(&i2c->done);
break;
case STATE_IDLE:
break;
--
2.7.4
next prev parent reply other threads:[~2016-08-03 12:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 12:03 [PATCH v0 0/4] Use complete() instead of complete_all() Daniel Wagner
2016-08-03 12:03 ` [PATCH v0 1/4] i2c: bcm-iproc: " Daniel Wagner
2016-08-03 16:36 ` Ray Jui
2016-08-03 12:03 ` [PATCH v0 2/4] i2c: bcm-kona: " Daniel Wagner
2016-08-03 16:38 ` Ray Jui
2016-08-05 4:16 ` Tim Kryger
2016-08-03 12:03 ` [PATCH v0 3/4] i2c: brcmstb: " Daniel Wagner
2016-08-03 16:00 ` Kamal Dasu
2016-08-03 12:03 ` Daniel Wagner [this message]
2016-08-16 13:12 ` [PATCH v0 4/4] i2c: meson: " Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470225791-16613-5-git-send-email-wagi@monom.org \
--to=wagi@monom.org \
--cc=b.galvani@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel.wagner@bmw-carit.de \
--cc=kdasu.kdev@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=tim.kryger@linaro.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).