From: Jon Hunter <jonathanh@nvidia.com>
To: Laxman Dewangan <ldewangan@nvidia.com>, Wolfram Sang <wsa@the-dreams.de>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, Jon Hunter <jonathanh@nvidia.com>
Subject: [PATCH V2 7/9] i2c: tegra: Simplify I2C resume
Date: Fri, 26 Aug 2016 14:09:03 +0100 [thread overview]
Message-ID: <1472216945-11818-8-git-send-email-jonathanh@nvidia.com> (raw)
In-Reply-To: <1472216945-11818-1-git-send-email-jonathanh@nvidia.com>
The I2C adapter is unlocked regardless of whether the tegra_i2c_init()
called during the resume is successful or not. However, if the
tegra_i2c_init() is not successful, then ->is_suspended is not set to
false. Simplify the resume code by only setting ->is_suspended to false
if tegra_i2c_init() is successful and return the error code from
tegra_i2c_init().
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
---
drivers/i2c/busses/i2c-tegra.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index bdb50258a9a8..3c27012fa96c 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -989,17 +989,12 @@ static int tegra_i2c_resume(struct device *dev)
i2c_lock_adapter(&i2c_dev->adapter);
ret = tegra_i2c_init(i2c_dev);
-
- if (ret) {
- i2c_unlock_adapter(&i2c_dev->adapter);
- return ret;
- }
-
- i2c_dev->is_suspended = false;
+ if (!ret)
+ i2c_dev->is_suspended = false;
i2c_unlock_adapter(&i2c_dev->adapter);
- return 0;
+ return ret;
}
static SIMPLE_DEV_PM_OPS(tegra_i2c_pm, tegra_i2c_suspend, tegra_i2c_resume);
--
2.1.4
next prev parent reply other threads:[~2016-08-26 13:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 13:08 [PATCH V2 0/9] Some Tegra I2C Updates Jon Hunter
2016-08-26 13:08 ` [PATCH V2 1/9] i2c: tegra: Fix lines over 80 characters Jon Hunter
2016-08-26 13:08 ` [PATCH V2 2/9] i2c: tegra: Use BIT macro Jon Hunter
2016-08-26 13:08 ` [PATCH V2 3/9] i2c: tegra: Fix missing blank lines after declarations Jon Hunter
2016-08-26 13:09 ` [PATCH V2 4/9] i2c: tegra: Add missing new line characters Jon Hunter
2016-08-26 13:09 ` [PATCH V2 5/9] i2c: tegra: Remove non device-tree support Jon Hunter
2016-08-26 13:09 ` [PATCH V2 6/9] i2c: tegra: Use device name for adapter name Jon Hunter
2016-08-26 13:09 ` Jon Hunter [this message]
2016-08-26 13:09 ` [PATCH V2 8/9] i2c: tegra: Add runtime power-management support Jon Hunter
2016-08-26 13:09 ` [PATCH V2 9/9] i2c: tegra: Add pinctrl support Jon Hunter
2016-08-26 15:55 ` Stephen Warren
2016-08-26 16:38 ` Jon Hunter
[not found] ` <4a650548-22f7-1841-d9a6-b6cd637ed4bd-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-08-26 16:59 ` Stephen Warren
2016-09-07 14:17 ` Linus Walleij
[not found] ` <1472216945-11818-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-08-26 15:56 ` [PATCH V2 0/9] Some Tegra I2C Updates Wolfram Sang
2016-08-26 16:41 ` Jon Hunter
2016-08-30 20:38 ` Wolfram Sang
2016-09-06 9:52 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472216945-11818-8-git-send-email-jonathanh@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=gnurou@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).