From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jean Delvare <jdelvare@suse.com>
Subject: [PATCH v5 4/6] i2c: i801: use the BIT() macro for FEATURES_* also
Date: Thu, 13 Oct 2016 14:10:38 +0200 [thread overview]
Message-ID: <1476360640-12901-5-git-send-email-benjamin.tissoires@redhat.com> (raw)
In-Reply-To: <1476360640-12901-1-git-send-email-benjamin.tissoires@redhat.com>
no functional changes
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
no changes in v5
no changes in v4
no changes in v3
new in v2
---
drivers/i2c/busses/i2c-i801.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index 5928ee2..88b2e31 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -270,15 +270,15 @@ struct i801_priv {
struct smbus_host_notify *host_notify;
};
-#define FEATURE_SMBUS_PEC (1 << 0)
-#define FEATURE_BLOCK_BUFFER (1 << 1)
-#define FEATURE_BLOCK_PROC (1 << 2)
-#define FEATURE_I2C_BLOCK_READ (1 << 3)
-#define FEATURE_IRQ (1 << 4)
-#define FEATURE_HOST_NOTIFY (1 << 5)
+#define FEATURE_SMBUS_PEC BIT(0)
+#define FEATURE_BLOCK_BUFFER BIT(1)
+#define FEATURE_BLOCK_PROC BIT(2)
+#define FEATURE_I2C_BLOCK_READ BIT(3)
+#define FEATURE_IRQ BIT(4)
+#define FEATURE_HOST_NOTIFY BIT(5)
/* Not really a feature, but it's convenient to handle it as such */
-#define FEATURE_IDF (1 << 15)
-#define FEATURE_TCO (1 << 16)
+#define FEATURE_IDF BIT(15)
+#define FEATURE_TCO BIT(16)
static const char *i801_feature_names[] = {
"SMBus PEC",
--
2.7.4
next prev parent reply other threads:[~2016-10-13 12:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 12:10 [PATCH v5 0/6] i2c: Host Notify / i801 fixes Benjamin Tissoires
2016-10-13 12:10 ` [PATCH v5 1/6] i2c: i801: store and restore the SLVCMD register at load and unload Benjamin Tissoires
2016-10-13 12:10 ` [PATCH v5 2/6] i2c: i801: minor formatting issues Benjamin Tissoires
2016-10-13 12:10 ` [PATCH v5 3/6] i2c: i801: use BIT() macro for bits definition Benjamin Tissoires
2016-10-13 12:10 ` Benjamin Tissoires [this message]
2016-10-13 12:10 ` [PATCH v5 5/6] i2c: i801: remove SMBNTFDDAT reads as they always seem to return 0 Benjamin Tissoires
2016-10-13 12:10 ` [PATCH v5 6/6] i2c: use an IRQ to report Host Notify events, not alert Benjamin Tissoires
2016-11-07 0:20 ` Wolfram Sang
2016-11-07 16:18 ` Benjamin Tissoires
2016-11-21 10:52 ` Benjamin Tissoires
2016-11-22 11:49 ` Wolfram Sang
2016-11-24 15:06 ` Wolfram Sang
2016-11-24 15:10 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476360640-12901-5-git-send-email-benjamin.tissoires@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).