From: Lucas Stach <l.stach@pengutronix.de>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, kernel@pengutronix.de,
patchwork-lst@pengutronix.de
Subject: Re: [PATCH] i2c: core: don't try to OF populate DDC i2c buses
Date: Wed, 30 Nov 2016 15:06:46 +0100 [thread overview]
Message-ID: <1480514806.2258.68.camel@pengutronix.de> (raw)
In-Reply-To: <d31d7cd0-4b00-4db0-2a51-cf3e553e6df8@mleia.com>
Am Mittwoch, den 30.11.2016, 15:54 +0200 schrieb Vladimir Zapolskiy:
> Hello Lucas,
>
> On 11/30/2016 01:50 PM, Lucas Stach wrote:
> > DDC buses are manually managed by their consumers to communicate
> > with the display. There is no need to try to populate OF childs.
> >
> > This gets rid of the device create failed warning caused by the
> > core trying to populate a DDC bus below a OF device, which has
> > other childs nodes, that aren't i2c devices.
>
> what kind of devices on a DDC bus represended by children nodes
> do you reference here?
None. The device registering the DDC i2c adapter might have an of_node.
The children of this device are not i2c devices, but for example port
nodes for the of_graph binding.
The same issue can be worked around if we make it explicit by placing an
"i2c-bus" subnode with no children into the parent device OF node. But
as the OF probing of devices on a DDC bus just doesn't make sense I
figured it would be good to just skip all this.
Regards,
Lucas
next prev parent reply other threads:[~2016-11-30 14:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 11:50 [PATCH] i2c: core: don't try to OF populate DDC i2c buses Lucas Stach
2016-11-30 13:21 ` Uwe Kleine-König
2016-11-30 13:54 ` Vladimir Zapolskiy
2016-11-30 14:06 ` Lucas Stach [this message]
2016-11-30 20:18 ` Vladimir Zapolskiy
2016-12-01 10:07 ` Lucas Stach
2016-12-01 12:23 ` Vladimir Zapolskiy
2016-12-11 22:16 ` Wolfram Sang
2017-01-13 10:14 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480514806.2258.68.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=patchwork-lst@pengutronix.de \
--cc=vz@mleia.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).