From: Qi Hou <qi.hou@windriver.com>
To: peda@axentia.se, stable@vger.kernel.org, robh@kernel.org,
linux-i2c@vger.kernel.org
Cc: leif.lindholm@linaro.org, pantelis.antoniou@konsulko.com,
grant.likely@linaro.org, bruce.ashfield@windriver.com,
paul.gortmaker@windriver.com, xiao.zhang@windriver.com
Subject: [PATCH] i2c: add missing of_node_put in i2c_mux_del_adapters
Date: Fri, 3 Mar 2017 15:57:11 +0800 [thread overview]
Message-ID: <1488527831-53733-1-git-send-email-qi.hou@windriver.com> (raw)
Refcount of of_node is increased with of_node_get() in i2c_mux_add_adapter().
It must be decreased with of_node_put() in i2c_mux_del_adapters().
Signe-off-by: Qi Hou <qi.hou@windriver.com>
Reviewed-by: Zhang Xiao <xiao.zhang@windriver.com>
Acked-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/i2c-mux.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/i2c-mux.c b/drivers/i2c/i2c-mux.c
index 83768e8..2178266 100644
--- a/drivers/i2c/i2c-mux.c
+++ b/drivers/i2c/i2c-mux.c
@@ -429,6 +429,7 @@ void i2c_mux_del_adapters(struct i2c_mux_core *muxc)
while (muxc->num_adapters) {
struct i2c_adapter *adap = muxc->adapter[--muxc->num_adapters];
struct i2c_mux_priv *priv = adap->algo_data;
+ struct device_node *np = adap->dev.of_node;
muxc->adapter[muxc->num_adapters] = NULL;
@@ -438,6 +439,7 @@ void i2c_mux_del_adapters(struct i2c_mux_core *muxc)
sysfs_remove_link(&priv->adap.dev.kobj, "mux_device");
i2c_del_adapter(adap);
+ of_node_put(np);
kfree(priv);
}
}
--
1.9.1
next reply other threads:[~2017-03-03 7:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 7:57 Qi Hou [this message]
2017-03-03 10:15 ` [PATCH] i2c: add missing of_node_put in i2c_mux_del_adapters Peter Rosin
2017-03-09 14:40 ` Wolfram Sang
2017-03-09 15:38 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488527831-53733-1-git-send-email-qi.hou@windriver.com \
--to=qi.hou@windriver.com \
--cc=bruce.ashfield@windriver.com \
--cc=grant.likely@linaro.org \
--cc=leif.lindholm@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=paul.gortmaker@windriver.com \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xiao.zhang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox