linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: liguo zhang <liguo.zhang@mediatek.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, Eddie Huang <eddie.huang@mediatek.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Daniel Kurtz <djkurtz@chromium.org>,
	Yingjoe Chen <yingjoe.chen@mediatek.com>,
	JunGao <jun.gao@mediatek.com>
Subject: Re: [PATCH] i2c: m65xx: drop superfluous quirk structure
Date: Tue, 7 Mar 2017 10:36:01 +0800	[thread overview]
Message-ID: <1488854161.8977.3.camel@mhfsdcap03> (raw)
In-Reply-To: <20170227192505.6449-1-wsa@the-dreams.de>

On Mon, 2017-02-27 at 20:25 +0100, Wolfram Sang wrote:
> All length fields in Linux I2C are u16, so a HW length limitation of 16
> bit lengths is not a limitation. Remove the quirk structure.
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
We have tested this patch and it is OK.
Tested-by:Jun Gao <jun.gao@mediatek.com>

> Compile tested only, don't have the hardware. Would appreciate if one of you
> had the time to test this. Thank you!
> 
>  drivers/i2c/busses/i2c-mt65xx.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> index 4a7d9bc2142ba3..45d61714c81bd2 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> @@ -172,14 +172,6 @@ static const struct i2c_adapter_quirks mt6577_i2c_quirks = {
>  	.max_comb_2nd_msg_len = 31,
>  };
>  
> -static const struct i2c_adapter_quirks mt8173_i2c_quirks = {
> -	.max_num_msgs = 65535,
> -	.max_write_len = 65535,
> -	.max_read_len = 65535,
> -	.max_comb_1st_msg_len = 65535,
> -	.max_comb_2nd_msg_len = 65535,
> -};
> -
>  static const struct mtk_i2c_compatible mt6577_compat = {
>  	.quirks = &mt6577_i2c_quirks,
>  	.pmic_i2c = 0,
> @@ -199,7 +191,6 @@ static const struct mtk_i2c_compatible mt6589_compat = {
>  };
>  
>  static const struct mtk_i2c_compatible mt8173_compat = {
> -	.quirks = &mt8173_i2c_quirks,
>  	.pmic_i2c = 0,
>  	.dcm = 1,
>  	.auto_restart = 1,

  reply	other threads:[~2017-03-07  2:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-27 19:25 [PATCH] i2c: m65xx: drop superfluous quirk structure Wolfram Sang
2017-03-07  2:36 ` liguo zhang [this message]
2017-03-07  8:05   ` Wolfram Sang
2017-03-09 14:41 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488854161.8977.3.camel@mhfsdcap03 \
    --to=liguo.zhang@mediatek.com \
    --cc=djkurtz@chromium.org \
    --cc=eddie.huang@mediatek.com \
    --cc=jun.gao@mediatek.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=wsa@the-dreams.de \
    --cc=yingjoe.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).