* [PATCH] i2c: meson: fix wrong variable usage in meson_i2c_put_data
@ 2017-03-07 20:06 Heiner Kallweit
2017-03-08 9:17 ` Jerome Brunet
2017-03-09 14:41 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Heiner Kallweit @ 2017-03-07 20:06 UTC (permalink / raw)
To: Wolfram Sang, Kevin Hilman; +Cc: linux-amlogic, linux-i2c@vger.kernel.org
Most likely a copy & paste error.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/i2c/busses/i2c-meson.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c
index 2aa61bbb..73b97c71 100644
--- a/drivers/i2c/busses/i2c-meson.c
+++ b/drivers/i2c/busses/i2c-meson.c
@@ -175,7 +175,7 @@ static void meson_i2c_put_data(struct meson_i2c *i2c, char *buf, int len)
wdata1 |= *buf++ << ((i - 4) * 8);
writel(wdata0, i2c->regs + REG_TOK_WDATA0);
- writel(wdata0, i2c->regs + REG_TOK_WDATA1);
+ writel(wdata1, i2c->regs + REG_TOK_WDATA1);
dev_dbg(i2c->dev, "%s: data %08x %08x len %d\n", __func__,
wdata0, wdata1, len);
--
2.12.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: meson: fix wrong variable usage in meson_i2c_put_data
2017-03-07 20:06 [PATCH] i2c: meson: fix wrong variable usage in meson_i2c_put_data Heiner Kallweit
@ 2017-03-08 9:17 ` Jerome Brunet
2017-03-09 14:41 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Jerome Brunet @ 2017-03-08 9:17 UTC (permalink / raw)
To: Heiner Kallweit, Wolfram Sang, Kevin Hilman
Cc: linux-amlogic, linux-i2c@vger.kernel.org
On Tue, 2017-03-07 at 21:06 +0100, Heiner Kallweit wrote:
> Most likely a copy & paste error.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/i2c/busses/i2c-meson.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c
> index 2aa61bbb..73b97c71 100644
> --- a/drivers/i2c/busses/i2c-meson.c
> +++ b/drivers/i2c/busses/i2c-meson.c
> @@ -175,7 +175,7 @@ static void meson_i2c_put_data(struct meson_i2c *i2c, char *buf, int len)
> wdata1 |= *buf++ << ((i - 4) * 8);
>
> writel(wdata0, i2c->regs + REG_TOK_WDATA0);
> - writel(wdata0, i2c->regs + REG_TOK_WDATA1);
> + writel(wdata1, i2c->regs + REG_TOK_WDATA1);
>
> dev_dbg(i2c->dev, "%s: data %08x %08x len %d\n", __func__,
> wdata0, wdata1, len);
Good catch, Strange it did not show up before.
You are just missing the Fixes tag.
Fixes: 30021e3707a7 ("i2c: add support for Amlogic Meson I2C controller")
Acked-by: Jerome Brunet <jbrunet@baylibre.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: meson: fix wrong variable usage in meson_i2c_put_data
2017-03-07 20:06 [PATCH] i2c: meson: fix wrong variable usage in meson_i2c_put_data Heiner Kallweit
2017-03-08 9:17 ` Jerome Brunet
@ 2017-03-09 14:41 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2017-03-09 14:41 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: Kevin Hilman, linux-amlogic, linux-i2c@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 201 bytes --]
On Tue, Mar 07, 2017 at 09:06:38PM +0100, Heiner Kallweit wrote:
> Most likely a copy & paste error.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-09 14:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-07 20:06 [PATCH] i2c: meson: fix wrong variable usage in meson_i2c_put_data Heiner Kallweit
2017-03-08 9:17 ` Jerome Brunet
2017-03-09 14:41 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).