From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Brunet Subject: Re: [PATCH 06/12] i2c: meson: remove variable count from meson_i2c_xfer Date: Wed, 08 Mar 2017 10:28:50 +0100 Message-ID: <1488965330.2514.12.camel@baylibre.com> References: <95687966-387c-f9ba-ae0a-9b0258f7ad43@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: Received: from mail-wm0-f49.google.com ([74.125.82.49]:37976 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752045AbdCHJhF (ORCPT ); Wed, 8 Mar 2017 04:37:05 -0500 Received: by mail-wm0-f49.google.com with SMTP id t189so25756171wmt.1 for ; Wed, 08 Mar 2017 01:36:44 -0800 (PST) In-Reply-To: <95687966-387c-f9ba-ae0a-9b0258f7ad43@gmail.com> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Heiner Kallweit , Wolfram Sang Cc: linux-amlogic@lists.infradead.org, "linux-i2c@vger.kernel.org" On Wed, 2017-03-08 at 07:46 +0100, Heiner Kallweit wrote: > Variable count has always the same value as i, so we don't need it. > In addition use &msgs[i] instead of msgs + i to improve readability > of code a little. > > Signed-off-by: Heiner Kallweit > --- >  drivers/i2c/busses/i2c-meson.c | 7 +++---- >  1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c > index 594fec22..81304840 100644 > --- a/drivers/i2c/busses/i2c-meson.c > +++ b/drivers/i2c/busses/i2c-meson.c > @@ -364,20 +364,19 @@ static int meson_i2c_xfer(struct i2c_adapter *adap, > struct i2c_msg *msgs, >     int num) >  { >   struct meson_i2c *i2c = adap->algo_data; > - int i, ret = 0, count = 0; > + int i, ret = 0; >   >   clk_enable(i2c->clk); >   >   for (i = 0; i < num; i++) { > - ret = meson_i2c_xfer_msg(i2c, msgs + i, i == num - 1); > + ret = meson_i2c_xfer_msg(i2c, &msgs[i], i == num - 1); It's a matter of taste whether this is more readable. I personally prefer it the way it was. >   if (ret) >   break; > - count++; >   } >   >   clk_disable(i2c->clk); >   > - return ret ? ret : count; > + return ret ?: i; >  } >   >  static u32 meson_i2c_func(struct i2c_adapter *adap)