From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Wolfram Sang <wsa@the-dreams.de>,
Sebastian Reichel <sre@kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-acpi@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, Bin Gao <bin.gao@intel.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>
Subject: Re: [PATCH 01/15] mfd: Add Cherry Trail Whiskey Cove PMIC driver
Date: Mon, 20 Mar 2017 14:55:05 +0200 [thread overview]
Message-ID: <1490014505.19767.103.camel@linux.intel.com> (raw)
In-Reply-To: <20170320104152.lba24r2qilpjr2kk@dell>
On Mon, 2017-03-20 at 10:41 +0000, Lee Jones wrote:
> On Fri, 17 Mar 2017, Andy Shevchenko wrote:
> > On Fri, 2017-03-17 at 10:55 +0100, Hans de Goede wrote:
> > > +enum {
> > > + CHT_WC_PWRSRC_IRQ = 0,
> > > + CHT_WC_THRM_IRQ,
> > > + CHT_WC_BCU_IRQ,
> > > + CHT_WC_ADC_IRQ,
> > > + CHT_WC_EXT_CHGR_IRQ,
> > > + CHT_WC_GPIO_IRQ,
> > > + /* There is no irq 6 */
> > > + CHT_WC_CRIT_IRQ = 7,
> >
> > I would prefer explicit over implicit (adding = N to each line), but
> > this is minor.
>
> No need. The C standard is clear on what is expected of enums.
I understand that, though I don't like gaps in enums. That's why I
prefer in such cases pure #define over enum (yes, I understand that enum
in many cases is better).
But this all matter of taste. So, I will not insist if it would be left
as it is now.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-03-20 12:55 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 9:55 [PATCH 00/15] Add Intel Cherry Trail Whiskey Cove PMIC support Hans de Goede
2017-03-17 9:55 ` [PATCH 01/15] mfd: Add Cherry Trail Whiskey Cove PMIC driver Hans de Goede
2017-03-17 17:00 ` Andy Shevchenko
2017-03-20 10:41 ` Lee Jones
2017-03-20 12:55 ` Andy Shevchenko [this message]
2017-03-17 9:55 ` [PATCH 02/15] ACPI / PMIC: Add opregion driver for Intel CHT Whiskey Cove PMIC Hans de Goede
2017-03-17 9:55 ` [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver Hans de Goede
2017-03-17 17:18 ` Andy Shevchenko
2017-03-20 18:08 ` Hans de Goede
2017-03-20 1:33 ` Chanwoo Choi
2017-03-20 13:00 ` Andy Shevchenko
2017-03-21 3:54 ` Chanwoo Choi
2017-03-21 5:21 ` Chanwoo Choi
2017-03-21 6:27 ` Chanwoo Choi
2017-03-20 19:57 ` Hans de Goede
2017-03-21 5:16 ` Chanwoo Choi
2017-03-23 15:22 ` Hans de Goede
2017-03-17 9:55 ` [PATCH 04/15] power: supply: bq24190_charger: Add no_register_reset pdata flag Hans de Goede
2017-03-17 17:20 ` Andy Shevchenko
2017-03-17 9:55 ` [PATCH 05/15] power: supply: bq24190_charger: Limit charging voltage to 4.3V Hans de Goede
2017-03-17 9:55 ` [PATCH 06/15] power: supply: bq24190_charger: Use i2c-core irq-mapping code Hans de Goede
2017-03-17 17:24 ` Andy Shevchenko
2017-03-20 4:46 ` Sebastian Reichel
2017-03-17 9:55 ` [PATCH 07/15] power: supply: bq24190_charger: Add support for bq24192[i] Hans de Goede
2017-03-17 9:55 ` [PATCH 08/15] power: supply: bq24190_charger: Add support for external fuel gauge Hans de Goede
2017-03-17 9:55 ` [PATCH 09/15] power: supply: bq24190_charger: Add voltage_max_design prop to battery Hans de Goede
2017-03-20 5:12 ` Sebastian Reichel
2017-03-17 9:55 ` [PATCH 10/15] power: supply: bq24190_charger: Use extcon to determine ilimit, 5v boost Hans de Goede
2017-03-17 17:33 ` Andy Shevchenko
2017-03-20 22:38 ` Hans de Goede
2017-03-20 4:52 ` Sebastian Reichel
2017-03-17 9:55 ` [PATCH 11/15] i2c: core: Allow getting ACPI info by index Hans de Goede
2017-03-17 17:35 ` Andy Shevchenko
2017-03-17 9:55 ` [PATCH 12/15] i2c: core: Add new i2c_acpi_new_device helper function Hans de Goede
2017-03-17 17:37 ` Andy Shevchenko
2017-03-22 15:59 ` Hans de Goede
2017-03-17 9:55 ` [PATCH 13/15] i2c: core: Allow drivers to specify index for irq to get from of / ACPI Hans de Goede
2017-03-17 17:41 ` Andy Shevchenko
2017-03-20 8:55 ` kbuild test robot
2017-03-17 9:55 ` [PATCH 14/15] power: supply: Add driver for Cherry Trail Whiskey Cove PMIC Fuel Gauge Hans de Goede
2017-03-17 17:58 ` Andy Shevchenko
2017-03-22 17:03 ` Hans de Goede
2017-03-20 5:07 ` Sebastian Reichel
2017-03-17 9:55 ` [PATCH 15/15] i2c-cht-wc: Add Intel Cherry Trail Whiskey Cove SMBUS controller driver Hans de Goede
2017-03-17 18:22 ` Andy Shevchenko
2017-03-23 13:58 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490014505.19767.103.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bin.gao@intel.com \
--cc=cw00.choi@samsung.com \
--cc=felipe.balbi@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rjw@rjwysocki.net \
--cc=sre@kernel.org \
--cc=tiwai@suse.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).