linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Reid <preid@electromag.com.au>
To: wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com,
	sre@kernel.org, peda@axentia.se, preid@electromag.com.au,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v5 8/9] power: supply: sbs-battery: Add alert callback
Date: Mon,  1 May 2017 16:49:58 +0800	[thread overview]
Message-ID: <1493628599-30552-9-git-send-email-preid@electromag.com.au> (raw)
In-Reply-To: <1493628599-30552-1-git-send-email-preid@electromag.com.au>

To simplify the sbs-manager code and notification of battery removal
use the i2c alert callback to notify the sbs-battery driver that an
event has occurred.

Signed-off-by: Phil Reid <preid@electromag.com.au>
---
 drivers/power/supply/sbs-battery.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c
index 8bb2eb3..a719892 100644
--- a/drivers/power/supply/sbs-battery.c
+++ b/drivers/power/supply/sbs-battery.c
@@ -675,21 +675,30 @@ static int sbs_get_property(struct power_supply *psy,
 	return 0;
 }
 
-static irqreturn_t sbs_irq(int irq, void *devid)
+static void sbs_supply_changed(struct sbs_info *chip)
 {
-	struct sbs_info *chip = devid;
 	struct power_supply *battery = chip->power_supply;
 	int ret;
 
 	ret = gpiod_get_value_cansleep(chip->gpio_detect);
 	if (ret < 0)
-		return ret;
+		return;
 	chip->is_present = ret;
 	power_supply_changed(battery);
+}
 
+static irqreturn_t sbs_irq(int irq, void *devid)
+{
+	sbs_supply_changed(devid);
 	return IRQ_HANDLED;
 }
 
+static void sbs_alert(struct i2c_client *client, enum i2c_alert_protocol prot,
+	unsigned int data)
+{
+	sbs_supply_changed(i2c_get_clientdata(client));
+}
+
 static void sbs_external_power_changed(struct power_supply *psy)
 {
 	struct sbs_info *chip = power_supply_get_drvdata(psy);
@@ -917,6 +926,7 @@ static int sbs_suspend(struct device *dev)
 static struct i2c_driver sbs_battery_driver = {
 	.probe		= sbs_probe,
 	.remove		= sbs_remove,
+	.alert		= sbs_alert,
 	.id_table	= sbs_id,
 	.driver = {
 		.name	= "sbs-battery",
-- 
1.8.3.1

  parent reply	other threads:[~2017-05-01  8:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-01  8:49 [PATCH v5 0/9] Add sbs-manager with smbalert support Phil Reid
2017-05-01  8:49 ` [PATCH v5 1/9] i2c: i2c-smbus: Support threaded irqs Phil Reid
2017-05-01  8:49 ` [PATCH v5 2/9] i2c: i2c-smbus: Add null ptr guard in smb_alert_probe Phil Reid
2017-05-01  8:49 ` [PATCH v5 3/9] i2c: i2c-smbus: add of_i2c_setup_smbus_alert Phil Reid
2017-05-01  8:49 ` [PATCH v5 4/9] i2c: core: call of_i2c_setup_smbus_alert in i2c_register_adapter Phil Reid
     [not found]   ` <1493628599-30552-5-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-05-02 17:42     ` kbuild test robot
2017-05-01  8:49 ` [PATCH v5 5/9] i2c: mux: pca954x: Call request irq after adding mux segments Phil Reid
2017-05-01  8:49 ` [PATCH v5 6/9] Documentation: Add sbs-manager device tree node documentation Phil Reid
     [not found]   ` <1493628599-30552-7-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-05-01 11:49     ` Sebastian Reichel
2017-05-01  8:49 ` [PATCH v5 7/9] power: Adds support for Smart Battery System Manager Phil Reid
     [not found]   ` <1493628599-30552-8-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-05-01 13:41     ` Sebastian Reichel
2017-05-02  2:20       ` Phil Reid
     [not found]         ` <bf4cf813-609c-1d92-2329-35e9176d0d28-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-05-02  7:12           ` Sebastian Reichel
2017-05-01  8:49 ` Phil Reid [this message]
     [not found]   ` <1493628599-30552-9-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-05-01 12:32     ` [PATCH v5 8/9] power: supply: sbs-battery: Add alert callback Sebastian Reichel
2017-05-01  8:49 ` [PATCH v5 9/9] power: supply: sbs-manager: Add alert callback and battery change notification Phil Reid
     [not found]   ` <1493628599-30552-10-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-05-01 13:50     ` Sebastian Reichel
2017-05-01  9:08 ` [PATCH v5 0/9] Add sbs-manager with smbalert support Wolfram Sang
2017-05-02 10:24   ` Benjamin Tissoires
     [not found]     ` <20170502102440.GC2382-/m+UfqrgI5QNLKR9yMNcA1aTQe2KTcn/@public.gmane.org>
2017-05-02 10:29       ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493628599-30552-9-git-send-email-preid@electromag.com.au \
    --to=preid@electromag.com.au \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=peda@axentia.se \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).