From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
chin.yew.tan@intel.com, mika.westerberg@linux.intel.com,
jarkko.nikula@linux.intel.com
Cc: wsa@the-dreams.de, linux-acpi@vger.kernel.org,
linux-i2c@vger.kernel.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: Regression: bd698d24b1b57: i2c: designware: Get selected speed mode sda-hold-time via ACPI
Date: Tue, 09 May 2017 17:54:11 +0300 [thread overview]
Message-ID: <1494341651.30052.82.camel@linux.intel.com> (raw)
In-Reply-To: <20170509140720.GA21122@red-moon>
On Tue, 2017-05-09 at 15:07 +0100, Lorenzo Pieralisi wrote:
> Hi guys,
>
> as a heads-up, with today mainline (commit 2868b2513aa7) I get the
> following splat on AMD Seattle, reverting the $SUBJECT commit "solves"
> the problem.
>
> My I2C knowledge is a bit limited but I am not sure I understand why
> we should be reading eg ss_hcnt/ss_lcnt depending on the dev->clk_freq
> but then i2c_dw_init() _always_ requires those values to be set for
> a given device. Again, I have no insights into I2C inner workings
> so apologies for the silly assumption/question.
>
> Please have a look into this, thanks.
Since there is no clock defined you got a warning.
It means either ID is not added to drivers/acpi/acpi_apd.c or
platform has wrong values and thus
dw_i2c_no_acpi_params should be expanded.
I have no such platform, so I can't tell which one is the right fix.
But it's not a revert by my opinion.
> [ 1.160597] ------------[ cut here ]------------
> [ 1.165207] WARNING: CPU: 0 PID: 1 at drivers/i2c/busses/i2c-
> designware-core.c:293 i2c_dw_clk_rate+0x20/0x30
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-05-09 14:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 14:07 Regression: bd698d24b1b57: i2c: designware: Get selected speed mode sda-hold-time via ACPI Lorenzo Pieralisi
2017-05-09 14:54 ` Andy Shevchenko [this message]
2017-05-09 15:52 ` Lorenzo Pieralisi
2017-05-09 16:20 ` Andy Shevchenko
2017-05-10 9:24 ` Lorenzo Pieralisi
2017-05-10 13:55 ` Jarkko Nikula
2017-05-18 12:24 ` Ard Biesheuvel
2017-05-18 13:05 ` Jarkko Nikula
2017-05-18 13:44 ` Ard Biesheuvel
2017-05-19 7:11 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494341651.30052.82.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=chin.yew.tan@intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).