From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 1/2] i2c: designware: Print clock freq on invalid clock freq error Date: Sat, 08 Jul 2017 16:54:29 +0300 Message-ID: <1499522069.22624.305.camel@linux.intel.com> References: <20170708131052.13524-1-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: Received: from mga11.intel.com ([192.55.52.93]:28676 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752701AbdGHN7D (ORCPT ); Sat, 8 Jul 2017 09:59:03 -0400 In-Reply-To: <20170708131052.13524-1-hdegoede@redhat.com> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Hans de Goede , Jarkko Nikula , Wolfram Sang , Mika Westerberg Cc: linux-i2c@vger.kernel.org On Sat, 2017-07-08 at 15:10 +0200, Hans de Goede wrote: > When we refuse to probe due to an invalid clock frequency, log > the frequency which is causing this error. Shouldn't it have \n as well? > > Signed-off-by: Hans de Goede > --- >  drivers/i2c/busses/i2c-designware-platdrv.c | 3 ++- >  1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c > b/drivers/i2c/busses/i2c-designware-platdrv.c > index d1263b82d646..d5acaf8d65bf 100644 > --- a/drivers/i2c/busses/i2c-designware-platdrv.c > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c > @@ -275,7 +275,8 @@ static int dw_i2c_plat_probe(struct > platform_device *pdev) >   if (dev->clk_freq != 100000 && dev->clk_freq != 400000 >       && dev->clk_freq != 1000000 && dev->clk_freq != 3400000) > { >   dev_err(&pdev->dev, > - "Only 100kHz, 400kHz, 1MHz and 3.4MHz > supported"); > + "%d Hz is unsupported, only 100kHz, 400kHz, > 1MHz and 3.4MHz are supported", > + dev->clk_freq); >   r = -EINVAL; >   goto exit_reset; >   } -- Andy Shevchenko Intel Finland Oy