From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Reid Subject: [PATCH v8 5/9] i2c: mux: pca954x: Return error if irq_create_mapping fails Date: Tue, 18 Jul 2017 16:19:40 +0800 Message-ID: <1500365984-61404-6-git-send-email-preid@electromag.com.au> References: <1500365984-61404-1-git-send-email-preid@electromag.com.au> Return-path: Received: from anchovy3.45ru.net.au ([203.30.46.155]:36473 "EHLO anchovy.45ru.net.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751424AbdGRIT5 (ORCPT ); Tue, 18 Jul 2017 04:19:57 -0400 In-Reply-To: <1500365984-61404-1-git-send-email-preid@electromag.com.au> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, sre@kernel.org, jdelvare@suse.com, jglauber@cavium.com, david.daney@cavium.com, peda@axentia.se, benjamin.tissoires@redhat.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org Cc: Phil Reid irq_create_mapping can return an error, report error to log and return. Cleanup will occur inprobe function when an error is returned. Suggested-by: Peter Rosin Signed-off-by: Phil Reid --- drivers/i2c/muxes/i2c-mux-pca954x.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c index 9867720..0594775 100644 --- a/drivers/i2c/muxes/i2c-mux-pca954x.c +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c @@ -309,6 +309,10 @@ static int pca954x_irq_setup(struct i2c_mux_core *muxc) for (c = 0; c < data->chip->nchans; c++) { irq = irq_create_mapping(data->irq, c); + if (irq <= 0) { + dev_err(&client->dev, "failed irq create map\n"); + return -EINVAL; + } irq_set_chip_data(irq, data); irq_set_chip_and_handler(irq, &pca954x_irq_chip, handle_simple_irq); -- 1.8.3.1