From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-i2c@vger.kernel.org
Cc: "Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Michal Simek" <michal.simek@xilinx.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Sekhar Nori" <nsekhar@ti.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Wolfram Sang" <wsa@the-dreams.de>,
"Joachim Eastwood" <manabian@gmail.com>,
"Kukjin Kim" <kgene@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Barry Song" <baohua@kernel.org>,
"Jon Mason" <jonmason@broadcom.com>,
"Kevin Hilman" <khilman@kernel.org>,
"Jarkko Nikula" <jarkko.nikula@linux.intel.com>,
linux-samsung-soc@vger.kernel.org, "Ray Jui" <rjui@broadcom.com>,
"Patrice Chotard" <patrice.chotard@st.com>
Subject: Re: [PATCH] i2c: use dev_get_drvdata() to get private data in suspend/resume hooks
Date: Fri, 28 Jul 2017 13:40:15 +0300 [thread overview]
Message-ID: <1501238415.29303.279.camel@linux.intel.com> (raw)
In-Reply-To: <1501172184-17102-1-git-send-email-yamada.masahiro@socionext.com>
On Fri, 2017-07-28 at 01:16 +0900, Masahiro Yamada wrote:
> Several drivers call to_platform_device() to get platform_device
> and pass it to platform_get_drvdata(). In platform_get_drvdata(),
> the platform_device is converted back to struct device again.
>
> Use dev_get_drvdata() to avoid platform_device/device dance.
>
I think it should be split on per driver basis.
In any case,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
(for DesignWare only)
> drivers/i2c/busses/i2c-designware-platdrv.c | 6 ++----
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c
> b/drivers/i2c/busses/i2c-designware-platdrv.c
> index 2ea6d0d25a01..abe1eca8d689 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -428,8 +428,7 @@ static void dw_i2c_plat_complete(struct device
> *dev)
> #ifdef CONFIG_PM
> static int dw_i2c_plat_suspend(struct device *dev)
> {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct dw_i2c_dev *i_dev = platform_get_drvdata(pdev);
> + struct dw_i2c_dev *i_dev = dev_get_drvdata(dev);
>
> i_dev->disable(i_dev);
> i2c_dw_plat_prepare_clk(i_dev, false);
> @@ -439,8 +438,7 @@ static int dw_i2c_plat_suspend(struct device *dev)
>
> static int dw_i2c_plat_resume(struct device *dev)
> {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct dw_i2c_dev *i_dev = platform_get_drvdata(pdev);
> + struct dw_i2c_dev *i_dev = dev_get_drvdata(dev);
>
> i2c_dw_plat_prepare_clk(i_dev, true);
> i_dev->init(i_dev);
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-07-28 10:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 16:16 [PATCH] i2c: use dev_get_drvdata() to get private data in suspend/resume hooks Masahiro Yamada
2017-07-28 10:40 ` Andy Shevchenko [this message]
2017-07-31 15:04 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501238415.29303.279.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=baohua@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jonmason@broadcom.com \
--cc=kgene@kernel.org \
--cc=khilman@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=mika.westerberg@linux.intel.com \
--cc=nsekhar@ti.com \
--cc=patrice.chotard@st.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=soren.brinkmann@xilinx.com \
--cc=wsa@the-dreams.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).