linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Douthit <stephend@adiengineering.com>
To: seth.heasley@intel.com, nhorman@tuxdriver.com
Cc: wsa@the-dreams.de, danp@adiengineering.com,
	stephend@adiengineering.com, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads
Date: Mon,  7 Aug 2017 17:10:58 -0400	[thread overview]
Message-ID: <1502140260-13789-1-git-send-email-stephend@adiengineering.com> (raw)

Hello all,

We ran into an issue where the ipmi_ssif and i2c-ismt drivers don't
agree on the format for data returned by i2c_smbus_read_block_data()

Looking at the traffic on the wire with a beagle analyzer:
-----
Packet Details   (Values in hex; [S] = Start condition;
                  [P] = Stop condition; * = No Ack)
[S] <10:R> 12 1C 01 00 00 80 02 1C 02 8F BE 12 00 25 12 41 01 00 00* [P]
-----

Looking at the matching kernel trace:
-----
kssif0010-759   [001] ....  1435.891090: smbus_read: i2c-0 a=010 f=0000 c=3 BLOCK_DATA
kssif0010-759   [001] ....  1436.202906: smbus_reply: i2c-0 a=010 f=0000 c=3 BLOCK_DATA l=20 [13-12-1c-01-00-00-80-02-1c-02-8f-be-12-00-25-12-41-01-00-00]
kssif0010-759   [001] ....  1436.202908: smbus_result: i2c-0 a=010 f=0000 c=3 BLOCK_DATA rd res=0
-----

So basically the byte count already precedes the data in the dma_buffer,
then the driver sticks desc->rxbytes in front of this resulting in the
trace above.

The first patch tackles this.

The second patch in the series adds a sanity check on the byte count
supplied by the slave device.  This might be a nice to have, but is
probably less critical.

-Steve

             reply	other threads:[~2017-08-07 21:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-07 21:10 Stephen Douthit [this message]
2017-08-07 21:10 ` [PATCH 1/2] i2c: ismt: Don't duplicate the receive length for block reads Stephen Douthit
2017-08-07 21:11 ` [PATCH 2/2] i2c: ismt: Return EMSGSIZE for block reads with bogus length Stephen Douthit
2017-08-14 19:31 ` [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads Wolfram Sang
2017-08-28 13:50   ` Stephen Douthit
2017-08-29 10:22     ` Wolfram Sang
2017-08-29 11:35       ` Neil Horman
2017-08-29 11:49         ` Wolfram Sang
2017-08-29 18:12           ` Dan Priamo
2017-08-29 20:08             ` Wolfram Sang
2017-08-29 20:10               ` Dan Priamo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1502140260-13789-1-git-send-email-stephend@adiengineering.com \
    --to=stephend@adiengineering.com \
    --cc=danp@adiengineering.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=seth.heasley@intel.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).