From: Phil Reid <preid@electromag.com.au>
To: realmz6@gmail.com, wsa@the-dreams.de, sre@kernel.org,
preid@electromag.com.au,
adi-buildroot-devel@lists.sourceforge.net,
linux-i2c@vger.kernel.org, linux-pm@vger.kernel.org,
jdelvare@suse.de, benjamin.tissoires@redhat.com
Subject: [RFC v2 0/3] i2c: core: move smbus_alert into i2c-core
Date: Tue, 28 Nov 2017 11:38:26 +0800 [thread overview]
Message-ID: <1511840309-37964-1-git-send-email-preid@electromag.com.au> (raw)
A part of the review of previous accepted series
"Add sbs-manager with smbalert support" Wolfram suggested moving
the smbus_alert driver module into the i2c-core.
This is a proposed implementation of that move.
I've also rename Kconfig and file name to reflect that this only
relates the smbus alert feature.
I think I've compile tested all the possible permutations of compiling
things as either builtin or module.
eg:
core Builtin, Driver Builin
core Builtin, Driver Module
core Module, Driver Module
Changes from v1:
- Add guard around of_i2c_setup_smbus_alert for builds
that include smbus-alert but are not CONFIG_OF
Phil Reid (3):
i2c: smbus: move of_i2c_setup_smbus_alert declaration to i2c-core.h
i2c: Kconfig: rename variable I2C_SMBUS to I2C_SMBUS_ALERT
i2c: core: move smbus_alert module into i2c-core
arch/blackfin/configs/BF527-TLL6527M_defconfig | 2 +-
drivers/i2c/Kconfig | 14 +-
drivers/i2c/Makefile | 2 +-
drivers/i2c/busses/Kconfig | 8 +-
drivers/i2c/i2c-core-base.c | 7 +
drivers/i2c/i2c-core-smbus-alert.c | 243 +++++++++++++++++++++++++
drivers/i2c/i2c-core-smbus.c | 22 ---
drivers/i2c/i2c-core.h | 22 +++
drivers/i2c/i2c-smbus.c | 217 ----------------------
drivers/power/supply/Kconfig | 2 +-
include/linux/i2c-smbus.h | 10 -
11 files changed, 284 insertions(+), 265 deletions(-)
create mode 100644 drivers/i2c/i2c-core-smbus-alert.c
delete mode 100644 drivers/i2c/i2c-smbus.c
--
1.8.3.1
next reply other threads:[~2017-11-28 3:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 3:38 Phil Reid [this message]
2017-11-28 3:38 ` [RFC v2 1/3] i2c: smbus: move of_i2c_setup_smbus_alert declaration to i2c-core.h Phil Reid
2017-11-28 3:38 ` [RFC v2 2/3] i2c: Kconfig: rename variable I2C_SMBUS to I2C_SMBUS_ALERT Phil Reid
2017-11-28 22:08 ` Jean Delvare
2017-11-29 1:58 ` Phil Reid
2017-11-29 12:48 ` Jean Delvare
2017-11-30 10:31 ` Phil Reid
2017-11-28 3:38 ` [RFC v2 3/3] i2c: core: move smbus_alert module into i2c-core Phil Reid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511840309-37964-1-git-send-email-preid@electromag.com.au \
--to=preid@electromag.com.au \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=benjamin.tissoires@redhat.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=realmz6@gmail.com \
--cc=sre@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).