From: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
To: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
'Guennadi Liakhovetski'
<g.liakhovetski-Mmb7MZpHnFY@public.gmane.org>
Cc: 'Wolfram Sang' <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 10/16] i2c: sh_mobile: remove unnecessary OOM messages
Date: Wed, 07 May 2014 09:22:27 +0200 [thread overview]
Message-ID: <1543145.hITqNnqynP@avalon> (raw)
In-Reply-To: <018e01cf69ac$a4479600$ecd6c200$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Hi Jingoo,
Thank you for the patch.
On Wednesday 07 May 2014 13:27:22 Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
>
> Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Acked-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
> ---
> drivers/i2c/busses/i2c-sh_mobile.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-sh_mobile.c
> b/drivers/i2c/busses/i2c-sh_mobile.c index 1d79585..fbc13e9 100644
> --- a/drivers/i2c/busses/i2c-sh_mobile.c
> +++ b/drivers/i2c/busses/i2c-sh_mobile.c
> @@ -665,10 +665,8 @@ static int sh_mobile_i2c_probe(struct platform_device
> *dev) int ret;
>
> pd = kzalloc(sizeof(struct sh_mobile_i2c_data), GFP_KERNEL);
> - if (pd == NULL) {
> - dev_err(&dev->dev, "cannot allocate private data\n");
> + if (pd == NULL)
> return -ENOMEM;
> - }
>
> pd->clk = clk_get(&dev->dev, NULL);
> if (IS_ERR(pd->clk)) {
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-05-07 7:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 4:14 [PATCH 00/16] i2c: remove unnecessary OOM messages Jingoo Han
[not found] ` <018301cf69aa$cb7987d0$626c9770$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-07 4:16 ` [PATCH 01/16] i2c: bcm2835: " Jingoo Han
2014-05-07 4:16 ` [PATCH 02/16] i2c: diolan-u2c: " Jingoo Han
[not found] ` <018601cf69ab$26b2f460$7418dd20$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-07 4:49 ` Guenter Roeck
2014-05-07 4:17 ` [PATCH 03/16] i2c: efm32: " Jingoo Han
[not found] ` <018701cf69ab$42fd89f0$c8f89dd0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-07 7:32 ` Uwe Kleine-König
2014-05-07 4:18 ` [PATCH 04/16] i2c: eg20t: " Jingoo Han
[not found] ` <018801cf69ab$70a79a30$51f6ce90$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-07 7:20 ` Jean Delvare
2014-05-07 4:19 ` [PATCH 05/16] i2c: exynos5: " Jingoo Han
2014-05-07 4:20 ` [PATCH 06/16] i2c: imx: " Jingoo Han
[not found] ` <018a01cf69ab$aef30540$0cd90fc0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-07 7:30 ` Uwe Kleine-König
2014-05-07 4:24 ` [PATCH 07/16] i2c: omap: " Jingoo Han
2014-05-07 4:37 ` Felipe Balbi
2014-05-07 4:26 ` [PATCH 08/16] i2c: rcar: " Jingoo Han
2014-05-07 4:26 ` [PATCH 09/16] i2c: s3c2410: " Jingoo Han
2014-05-07 4:27 ` [PATCH 10/16] i2c: sh_mobile: " Jingoo Han
[not found] ` <018e01cf69ac$a4479600$ecd6c200$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-07 7:22 ` Laurent Pinchart [this message]
2014-05-07 4:28 ` [PATCH 11/16] i2c: simtec: " Jingoo Han
2014-05-07 4:29 ` [PATCH 12/16] i2c: sirf: " Jingoo Han
2014-05-07 4:29 ` [PATCH 13/16] i2c: stu300: " Jingoo Han
[not found] ` <019101cf69ac$f7d1ffe0$e775ffa0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-09 8:56 ` Linus Walleij
2014-05-07 4:30 ` [PATCH 14/16] i2c: tegra: " Jingoo Han
2014-05-07 4:31 ` [PATCH 15/16] i2c: wmt: " Jingoo Han
2014-05-07 4:32 ` [PATCH 16/16] i2c: scx200_acb: " Jingoo Han
2014-05-11 11:22 ` [PATCH 00/16] i2c: " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543145.hITqNnqynP@avalon \
--to=laurent.pinchart-rylnwiuwjnjg/c1bvhzhaw@public.gmane.org \
--cc=g.liakhovetski-Mmb7MZpHnFY@public.gmane.org \
--cc=jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).