* [PATCH 01/16] i2c: bcm2835: remove unnecessary OOM messages
[not found] ` <018301cf69aa$cb7987d0$626c9770$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2014-05-07 4:16 ` Jingoo Han
2014-05-07 4:16 ` [PATCH 02/16] i2c: diolan-u2c: " Jingoo Han
` (15 subsequent siblings)
16 siblings, 0 replies; 25+ messages in thread
From: Jingoo Han @ 2014-05-07 4:16 UTC (permalink / raw)
To: 'Wolfram Sang'
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, 'Jingoo Han',
'Stephen Warren'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
drivers/i2c/busses/i2c-bcm2835.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
index c607195..214ff97 100644
--- a/drivers/i2c/busses/i2c-bcm2835.c
+++ b/drivers/i2c/busses/i2c-bcm2835.c
@@ -225,10 +225,8 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
struct i2c_adapter *adap;
i2c_dev = devm_kzalloc(&pdev->dev, sizeof(*i2c_dev), GFP_KERNEL);
- if (!i2c_dev) {
- dev_err(&pdev->dev, "Cannot allocate i2c_dev\n");
+ if (!i2c_dev)
return -ENOMEM;
- }
platform_set_drvdata(pdev, i2c_dev);
i2c_dev->dev = &pdev->dev;
init_completion(&i2c_dev->completion);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 02/16] i2c: diolan-u2c: remove unnecessary OOM messages
[not found] ` <018301cf69aa$cb7987d0$626c9770$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-07 4:16 ` [PATCH 01/16] i2c: bcm2835: " Jingoo Han
@ 2014-05-07 4:16 ` Jingoo Han
[not found] ` <018601cf69ab$26b2f460$7418dd20$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-07 4:17 ` [PATCH 03/16] i2c: efm32: " Jingoo Han
` (14 subsequent siblings)
16 siblings, 1 reply; 25+ messages in thread
From: Jingoo Han @ 2014-05-07 4:16 UTC (permalink / raw)
To: 'Wolfram Sang'
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, 'Jingoo Han',
'Guenter Roeck'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
drivers/i2c/busses/i2c-diolan-u2c.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-diolan-u2c.c b/drivers/i2c/busses/i2c-diolan-u2c.c
index 721f7eb..b19a310 100644
--- a/drivers/i2c/busses/i2c-diolan-u2c.c
+++ b/drivers/i2c/busses/i2c-diolan-u2c.c
@@ -455,7 +455,6 @@ static int diolan_u2c_probe(struct usb_interface *interface,
/* allocate memory for our device state and initialize it */
dev = kzalloc(sizeof(*dev), GFP_KERNEL);
if (dev == NULL) {
- dev_err(&interface->dev, "no memory for device state\n");
ret = -ENOMEM;
goto error;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 03/16] i2c: efm32: remove unnecessary OOM messages
[not found] ` <018301cf69aa$cb7987d0$626c9770$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-07 4:16 ` [PATCH 01/16] i2c: bcm2835: " Jingoo Han
2014-05-07 4:16 ` [PATCH 02/16] i2c: diolan-u2c: " Jingoo Han
@ 2014-05-07 4:17 ` Jingoo Han
[not found] ` <018701cf69ab$42fd89f0$c8f89dd0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-07 4:18 ` [PATCH 04/16] i2c: eg20t: " Jingoo Han
` (13 subsequent siblings)
16 siblings, 1 reply; 25+ messages in thread
From: Jingoo Han @ 2014-05-07 4:17 UTC (permalink / raw)
To: 'Wolfram Sang'
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, 'Jingoo Han',
'Uwe Kleine-König'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
drivers/i2c/busses/i2c-efm32.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.c
index 777ed40..f7eccd6 100644
--- a/drivers/i2c/busses/i2c-efm32.c
+++ b/drivers/i2c/busses/i2c-efm32.c
@@ -320,10 +320,8 @@ static int efm32_i2c_probe(struct platform_device *pdev)
return -EINVAL;
ddata = devm_kzalloc(&pdev->dev, sizeof(*ddata), GFP_KERNEL);
- if (!ddata) {
- dev_dbg(&pdev->dev, "failed to allocate private data\n");
+ if (!ddata)
return -ENOMEM;
- }
platform_set_drvdata(pdev, ddata);
init_completion(&ddata->done);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 04/16] i2c: eg20t: remove unnecessary OOM messages
[not found] ` <018301cf69aa$cb7987d0$626c9770$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
` (2 preceding siblings ...)
2014-05-07 4:17 ` [PATCH 03/16] i2c: efm32: " Jingoo Han
@ 2014-05-07 4:18 ` Jingoo Han
[not found] ` <018801cf69ab$70a79a30$51f6ce90$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-07 4:19 ` [PATCH 05/16] i2c: exynos5: " Jingoo Han
` (12 subsequent siblings)
16 siblings, 1 reply; 25+ messages in thread
From: Jingoo Han @ 2014-05-07 4:18 UTC (permalink / raw)
To: 'Wolfram Sang'
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, 'Jingoo Han',
'Jean Delvare', 'Tomoya MORINAGA'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
drivers/i2c/busses/i2c-eg20t.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c
index ff775ac..a44ea13 100644
--- a/drivers/i2c/busses/i2c-eg20t.c
+++ b/drivers/i2c/busses/i2c-eg20t.c
@@ -751,10 +751,8 @@ static int pch_i2c_probe(struct pci_dev *pdev,
pch_pci_dbg(pdev, "Entered.\n");
adap_info = kzalloc((sizeof(struct adapter_info)), GFP_KERNEL);
- if (adap_info == NULL) {
- pch_pci_err(pdev, "Memory allocation FAILED\n");
+ if (adap_info == NULL)
return -ENOMEM;
- }
ret = pci_enable_device(pdev);
if (ret) {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 05/16] i2c: exynos5: remove unnecessary OOM messages
[not found] ` <018301cf69aa$cb7987d0$626c9770$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
` (3 preceding siblings ...)
2014-05-07 4:18 ` [PATCH 04/16] i2c: eg20t: " Jingoo Han
@ 2014-05-07 4:19 ` Jingoo Han
2014-05-07 4:20 ` [PATCH 06/16] i2c: imx: " Jingoo Han
` (11 subsequent siblings)
16 siblings, 0 replies; 25+ messages in thread
From: Jingoo Han @ 2014-05-07 4:19 UTC (permalink / raw)
To: 'Wolfram Sang'
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, 'Jingoo Han',
'Naveen Krishna Ch'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
drivers/i2c/busses/i2c-exynos5.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c
index 00af0a0..ce7c315 100644
--- a/drivers/i2c/busses/i2c-exynos5.c
+++ b/drivers/i2c/busses/i2c-exynos5.c
@@ -621,10 +621,8 @@ static int exynos5_i2c_probe(struct platform_device *pdev)
int ret;
i2c = devm_kzalloc(&pdev->dev, sizeof(struct exynos5_i2c), GFP_KERNEL);
- if (!i2c) {
- dev_err(&pdev->dev, "no memory for state\n");
+ if (!i2c)
return -ENOMEM;
- }
if (of_property_read_u32(np, "clock-frequency", &op_clock)) {
i2c->speed_mode = HSI2C_FAST_SPD;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 06/16] i2c: imx: remove unnecessary OOM messages
[not found] ` <018301cf69aa$cb7987d0$626c9770$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
` (4 preceding siblings ...)
2014-05-07 4:19 ` [PATCH 05/16] i2c: exynos5: " Jingoo Han
@ 2014-05-07 4:20 ` Jingoo Han
[not found] ` <018a01cf69ab$aef30540$0cd90fc0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-07 4:24 ` [PATCH 07/16] i2c: omap: " Jingoo Han
` (10 subsequent siblings)
16 siblings, 1 reply; 25+ messages in thread
From: Jingoo Han @ 2014-05-07 4:20 UTC (permalink / raw)
To: 'Wolfram Sang'
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, 'Jingoo Han',
'Uwe Kleine-König', 'Sascha Hauer'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
drivers/i2c/busses/i2c-imx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index db895fb..584e002 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -617,10 +617,8 @@ static int i2c_imx_probe(struct platform_device *pdev)
i2c_imx = devm_kzalloc(&pdev->dev, sizeof(struct imx_i2c_struct),
GFP_KERNEL);
- if (!i2c_imx) {
- dev_err(&pdev->dev, "can't allocate interface\n");
+ if (!i2c_imx)
return -ENOMEM;
- }
if (of_id)
i2c_imx->hwdata = of_id->data;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 07/16] i2c: omap: remove unnecessary OOM messages
[not found] ` <018301cf69aa$cb7987d0$626c9770$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
` (5 preceding siblings ...)
2014-05-07 4:20 ` [PATCH 06/16] i2c: imx: " Jingoo Han
@ 2014-05-07 4:24 ` Jingoo Han
2014-05-07 4:37 ` Felipe Balbi
2014-05-07 4:26 ` [PATCH 08/16] i2c: rcar: " Jingoo Han
` (9 subsequent siblings)
16 siblings, 1 reply; 25+ messages in thread
From: Jingoo Han @ 2014-05-07 4:24 UTC (permalink / raw)
To: 'Wolfram Sang'
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, 'Jingoo Han',
'Felipe Balbi', 'Shubhrajyoti D'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
drivers/i2c/busses/i2c-omap.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 85f8eac..b182793 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1114,10 +1114,8 @@ omap_i2c_probe(struct platform_device *pdev)
}
dev = devm_kzalloc(&pdev->dev, sizeof(struct omap_i2c_dev), GFP_KERNEL);
- if (!dev) {
- dev_err(&pdev->dev, "Menory allocation failed\n");
+ if (!dev)
return -ENOMEM;
- }
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
dev->base = devm_ioremap_resource(&pdev->dev, mem);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 07/16] i2c: omap: remove unnecessary OOM messages
2014-05-07 4:24 ` [PATCH 07/16] i2c: omap: " Jingoo Han
@ 2014-05-07 4:37 ` Felipe Balbi
0 siblings, 0 replies; 25+ messages in thread
From: Felipe Balbi @ 2014-05-07 4:37 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Wolfram Sang', linux-i2c, 'Felipe Balbi',
Linux OMAP Mailing List
[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]
On Wed, May 07, 2014 at 01:24:23PM +0900, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Felipe Balbi <balbi@ti.com>
> ---
> drivers/i2c/busses/i2c-omap.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 85f8eac..b182793 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -1114,10 +1114,8 @@ omap_i2c_probe(struct platform_device *pdev)
> }
>
> dev = devm_kzalloc(&pdev->dev, sizeof(struct omap_i2c_dev), GFP_KERNEL);
> - if (!dev) {
> - dev_err(&pdev->dev, "Menory allocation failed\n");
> + if (!dev)
> return -ENOMEM;
> - }
>
> mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> dev->base = devm_ioremap_resource(&pdev->dev, mem);
> --
> 1.7.10.4
>
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 08/16] i2c: rcar: remove unnecessary OOM messages
[not found] ` <018301cf69aa$cb7987d0$626c9770$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
` (6 preceding siblings ...)
2014-05-07 4:24 ` [PATCH 07/16] i2c: omap: " Jingoo Han
@ 2014-05-07 4:26 ` Jingoo Han
2014-05-07 4:26 ` [PATCH 09/16] i2c: s3c2410: " Jingoo Han
` (8 subsequent siblings)
16 siblings, 0 replies; 25+ messages in thread
From: Jingoo Han @ 2014-05-07 4:26 UTC (permalink / raw)
To: 'Wolfram Sang'
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, 'Jingoo Han',
'Ben Dooks', 'Guennadi Liakhovetski'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
drivers/i2c/busses/i2c-rcar.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c
index d4fa8eb..6a63bfd 100644
--- a/drivers/i2c/busses/i2c-rcar.c
+++ b/drivers/i2c/busses/i2c-rcar.c
@@ -654,10 +654,8 @@ static int rcar_i2c_probe(struct platform_device *pdev)
int ret;
priv = devm_kzalloc(dev, sizeof(struct rcar_i2c_priv), GFP_KERNEL);
- if (!priv) {
- dev_err(dev, "no mem for private data\n");
+ if (!priv)
return -ENOMEM;
- }
priv->clk = devm_clk_get(dev, NULL);
if (IS_ERR(priv->clk)) {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 09/16] i2c: s3c2410: remove unnecessary OOM messages
[not found] ` <018301cf69aa$cb7987d0$626c9770$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
` (7 preceding siblings ...)
2014-05-07 4:26 ` [PATCH 08/16] i2c: rcar: " Jingoo Han
@ 2014-05-07 4:26 ` Jingoo Han
2014-05-07 4:27 ` [PATCH 10/16] i2c: sh_mobile: " Jingoo Han
` (7 subsequent siblings)
16 siblings, 0 replies; 25+ messages in thread
From: Jingoo Han @ 2014-05-07 4:26 UTC (permalink / raw)
To: 'Wolfram Sang'
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, 'Jingoo Han'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
drivers/i2c/busses/i2c-s3c2410.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index ae44910..0bb14bd 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1114,16 +1114,12 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
}
i2c = devm_kzalloc(&pdev->dev, sizeof(struct s3c24xx_i2c), GFP_KERNEL);
- if (!i2c) {
- dev_err(&pdev->dev, "no memory for state\n");
+ if (!i2c)
return -ENOMEM;
- }
i2c->pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
- if (!i2c->pdata) {
- dev_err(&pdev->dev, "no memory for platform data\n");
+ if (!i2c->pdata)
return -ENOMEM;
- }
i2c->quirks = s3c24xx_get_device_quirks(pdev);
if (pdata)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 10/16] i2c: sh_mobile: remove unnecessary OOM messages
[not found] ` <018301cf69aa$cb7987d0$626c9770$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
` (8 preceding siblings ...)
2014-05-07 4:26 ` [PATCH 09/16] i2c: s3c2410: " Jingoo Han
@ 2014-05-07 4:27 ` Jingoo Han
[not found] ` <018e01cf69ac$a4479600$ecd6c200$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-07 4:28 ` [PATCH 11/16] i2c: simtec: " Jingoo Han
` (6 subsequent siblings)
16 siblings, 1 reply; 25+ messages in thread
From: Jingoo Han @ 2014-05-07 4:27 UTC (permalink / raw)
To: 'Wolfram Sang'
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, 'Jingoo Han',
'Laurent Pinchart', 'Guennadi Liakhovetski'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
drivers/i2c/busses/i2c-sh_mobile.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c
index 1d79585..fbc13e9 100644
--- a/drivers/i2c/busses/i2c-sh_mobile.c
+++ b/drivers/i2c/busses/i2c-sh_mobile.c
@@ -665,10 +665,8 @@ static int sh_mobile_i2c_probe(struct platform_device *dev)
int ret;
pd = kzalloc(sizeof(struct sh_mobile_i2c_data), GFP_KERNEL);
- if (pd == NULL) {
- dev_err(&dev->dev, "cannot allocate private data\n");
+ if (pd == NULL)
return -ENOMEM;
- }
pd->clk = clk_get(&dev->dev, NULL);
if (IS_ERR(pd->clk)) {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 11/16] i2c: simtec: remove unnecessary OOM messages
[not found] ` <018301cf69aa$cb7987d0$626c9770$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
` (9 preceding siblings ...)
2014-05-07 4:27 ` [PATCH 10/16] i2c: sh_mobile: " Jingoo Han
@ 2014-05-07 4:28 ` Jingoo Han
2014-05-07 4:29 ` [PATCH 12/16] i2c: sirf: " Jingoo Han
` (5 subsequent siblings)
16 siblings, 0 replies; 25+ messages in thread
From: Jingoo Han @ 2014-05-07 4:28 UTC (permalink / raw)
To: 'Wolfram Sang'
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, 'Jingoo Han',
'Ben Dooks'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
drivers/i2c/busses/i2c-simtec.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-simtec.c b/drivers/i2c/busses/i2c-simtec.c
index 294c80f..964e5c6 100644
--- a/drivers/i2c/busses/i2c-simtec.c
+++ b/drivers/i2c/busses/i2c-simtec.c
@@ -77,10 +77,8 @@ static int simtec_i2c_probe(struct platform_device *dev)
int ret;
pd = kzalloc(sizeof(struct simtec_i2c_data), GFP_KERNEL);
- if (pd == NULL) {
- dev_err(&dev->dev, "cannot allocate private data\n");
+ if (pd == NULL)
return -ENOMEM;
- }
platform_set_drvdata(dev, pd);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 12/16] i2c: sirf: remove unnecessary OOM messages
[not found] ` <018301cf69aa$cb7987d0$626c9770$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
` (10 preceding siblings ...)
2014-05-07 4:28 ` [PATCH 11/16] i2c: simtec: " Jingoo Han
@ 2014-05-07 4:29 ` Jingoo Han
2014-05-07 4:29 ` [PATCH 13/16] i2c: stu300: " Jingoo Han
` (4 subsequent siblings)
16 siblings, 0 replies; 25+ messages in thread
From: Jingoo Han @ 2014-05-07 4:29 UTC (permalink / raw)
To: 'Wolfram Sang'
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, 'Jingoo Han',
'Zhiwu Song', 'Barry Song'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
drivers/i2c/busses/i2c-sirf.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-sirf.c b/drivers/i2c/busses/i2c-sirf.c
index 8e3be7e..a3216de 100644
--- a/drivers/i2c/busses/i2c-sirf.c
+++ b/drivers/i2c/busses/i2c-sirf.c
@@ -307,7 +307,6 @@ static int i2c_sirfsoc_probe(struct platform_device *pdev)
siic = devm_kzalloc(&pdev->dev, sizeof(*siic), GFP_KERNEL);
if (!siic) {
- dev_err(&pdev->dev, "Can't allocate driver data\n");
err = -ENOMEM;
goto out;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 13/16] i2c: stu300: remove unnecessary OOM messages
[not found] ` <018301cf69aa$cb7987d0$626c9770$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
` (11 preceding siblings ...)
2014-05-07 4:29 ` [PATCH 12/16] i2c: sirf: " Jingoo Han
@ 2014-05-07 4:29 ` Jingoo Han
[not found] ` <019101cf69ac$f7d1ffe0$e775ffa0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-07 4:30 ` [PATCH 14/16] i2c: tegra: " Jingoo Han
` (3 subsequent siblings)
16 siblings, 1 reply; 25+ messages in thread
From: Jingoo Han @ 2014-05-07 4:29 UTC (permalink / raw)
To: 'Wolfram Sang'
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, 'Jingoo Han',
'Linus Walleij'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
drivers/i2c/busses/i2c-stu300.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-stu300.c b/drivers/i2c/busses/i2c-stu300.c
index 29b1fb7..fefb1c1 100644
--- a/drivers/i2c/busses/i2c-stu300.c
+++ b/drivers/i2c/busses/i2c-stu300.c
@@ -868,10 +868,8 @@ static int stu300_probe(struct platform_device *pdev)
int ret = 0;
dev = devm_kzalloc(&pdev->dev, sizeof(struct stu300_dev), GFP_KERNEL);
- if (!dev) {
- dev_err(&pdev->dev, "could not allocate device struct\n");
+ if (!dev)
return -ENOMEM;
- }
bus_nr = pdev->id;
dev->clk = devm_clk_get(&pdev->dev, NULL);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 14/16] i2c: tegra: remove unnecessary OOM messages
[not found] ` <018301cf69aa$cb7987d0$626c9770$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
` (12 preceding siblings ...)
2014-05-07 4:29 ` [PATCH 13/16] i2c: stu300: " Jingoo Han
@ 2014-05-07 4:30 ` Jingoo Han
2014-05-07 4:31 ` [PATCH 15/16] i2c: wmt: " Jingoo Han
` (2 subsequent siblings)
16 siblings, 0 replies; 25+ messages in thread
From: Jingoo Han @ 2014-05-07 4:30 UTC (permalink / raw)
To: 'Wolfram Sang'
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, 'Jingoo Han',
'Stephen Warren'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
drivers/i2c/busses/i2c-tegra.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index 00f04cb..f1bb2fc 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -732,10 +732,8 @@ static int tegra_i2c_probe(struct platform_device *pdev)
}
i2c_dev = devm_kzalloc(&pdev->dev, sizeof(*i2c_dev), GFP_KERNEL);
- if (!i2c_dev) {
- dev_err(&pdev->dev, "Could not allocate struct tegra_i2c_dev");
+ if (!i2c_dev)
return -ENOMEM;
- }
i2c_dev->base = base;
i2c_dev->div_clk = div_clk;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 15/16] i2c: wmt: remove unnecessary OOM messages
[not found] ` <018301cf69aa$cb7987d0$626c9770$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
` (13 preceding siblings ...)
2014-05-07 4:30 ` [PATCH 14/16] i2c: tegra: " Jingoo Han
@ 2014-05-07 4:31 ` Jingoo Han
2014-05-07 4:32 ` [PATCH 16/16] i2c: scx200_acb: " Jingoo Han
2014-05-11 11:22 ` [PATCH 00/16] i2c: " Wolfram Sang
16 siblings, 0 replies; 25+ messages in thread
From: Jingoo Han @ 2014-05-07 4:31 UTC (permalink / raw)
To: 'Wolfram Sang'
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, 'Jingoo Han',
'Tony Prisk'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
drivers/i2c/busses/i2c-wmt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-wmt.c b/drivers/i2c/busses/i2c-wmt.c
index 2c8a3e4..889a212 100644
--- a/drivers/i2c/busses/i2c-wmt.c
+++ b/drivers/i2c/busses/i2c-wmt.c
@@ -379,10 +379,8 @@ static int wmt_i2c_probe(struct platform_device *pdev)
u32 clk_rate;
i2c_dev = devm_kzalloc(&pdev->dev, sizeof(*i2c_dev), GFP_KERNEL);
- if (!i2c_dev) {
- dev_err(&pdev->dev, "device memory allocation failed\n");
+ if (!i2c_dev)
return -ENOMEM;
- }
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
i2c_dev->base = devm_ioremap_resource(&pdev->dev, res);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 16/16] i2c: scx200_acb: remove unnecessary OOM messages
[not found] ` <018301cf69aa$cb7987d0$626c9770$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
` (14 preceding siblings ...)
2014-05-07 4:31 ` [PATCH 15/16] i2c: wmt: " Jingoo Han
@ 2014-05-07 4:32 ` Jingoo Han
2014-05-11 11:22 ` [PATCH 00/16] i2c: " Wolfram Sang
16 siblings, 0 replies; 25+ messages in thread
From: Jingoo Han @ 2014-05-07 4:32 UTC (permalink / raw)
To: 'Wolfram Sang'
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, 'Jingoo Han'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
drivers/i2c/busses/scx200_acb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c
index cb66f95..ff3f574 100644
--- a/drivers/i2c/busses/scx200_acb.c
+++ b/drivers/i2c/busses/scx200_acb.c
@@ -431,10 +431,8 @@ static struct scx200_acb_iface *scx200_create_iface(const char *text,
struct i2c_adapter *adapter;
iface = kzalloc(sizeof(*iface), GFP_KERNEL);
- if (!iface) {
- pr_err("can't allocate memory\n");
+ if (!iface)
return NULL;
- }
adapter = &iface->adapter;
i2c_set_adapdata(adapter, iface);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 00/16] i2c: remove unnecessary OOM messages
[not found] ` <018301cf69aa$cb7987d0$626c9770$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
` (15 preceding siblings ...)
2014-05-07 4:32 ` [PATCH 16/16] i2c: scx200_acb: " Jingoo Han
@ 2014-05-11 11:22 ` Wolfram Sang
16 siblings, 0 replies; 25+ messages in thread
From: Wolfram Sang @ 2014-05-11 11:22 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 320 bytes --]
On Wed, May 07, 2014 at 01:14:09PM +0900, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message. For example,
> k.alloc and v.alloc failures use dump_stack().
Yup. Yet, this is trivial stuff, please make it one patch for the
whole subsystem.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread