From: Sowjanya Komatineni <skomatineni@nvidia.com>
To: thierry.reding@gmail.com, jonathanh@nvidia.com,
mkarthik@nvidia.com, smohammed@nvidia.com, talho@nvidia.com
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org,
Sowjanya Komatineni <skomatineni@nvidia.com>
Subject: [PATCH V3 2/3] i2c: tegra: Update transfer timeout
Date: Fri, 25 Jan 2019 19:57:52 -0800 [thread overview]
Message-ID: <1548475073-12408-2-git-send-email-skomatineni@nvidia.com> (raw)
In-Reply-To: <1548475073-12408-1-git-send-email-skomatineni@nvidia.com>
Update I2C transfer timeout based on transfer bytes and I2C bus
rate to allow enough time during max transfer size based on the
speed.
Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
---
[V3] : Same as V2
[V2] : Added this patch in V2 series to allow enough time for data transfer
to happen.
This patch has dependency with DMA patch as TEGRA_I2C_TIMEOUT define
takes argument with this patch.
drivers/i2c/busses/i2c-tegra.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index aec500ef9a98..3dcbc9960d9d 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -23,7 +23,7 @@
#include <linux/reset.h>
#include <linux/slab.h>
-#define TEGRA_I2C_TIMEOUT (msecs_to_jiffies(1000))
+#define TEGRA_I2C_TIMEOUT(ms) (msecs_to_jiffies(ms))
#define BYTES_PER_FIFO_WORD 4
#define I2C_CNFG 0x000
@@ -116,6 +116,9 @@
#define I2C_MST_FIFO_STATUS_TX_MASK 0xff0000
#define I2C_MST_FIFO_STATUS_TX_SHIFT 16
+/* Packet header size in bytes */
+#define I2C_PACKET_HEADER_SIZE 12
+
/*
* msg_end_type: The bus control which need to be send at end of transfer.
* @MSG_END_STOP: Send stop pulse at end of transfer.
@@ -683,6 +686,17 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev,
u32 int_mask;
unsigned long time_left;
unsigned long flags;
+ u16 xfer_time = 100;
+ size_t xfer_size = 0;
+
+ if (msg->flags & I2C_M_RD)
+ xfer_size = ALIGN(msg->len, BYTES_PER_FIFO_WORD);
+ else
+ xfer_size = ALIGN(msg->len, BYTES_PER_FIFO_WORD) +
+ I2C_PACKET_HEADER_SIZE;
+
+ xfer_time += DIV_ROUND_CLOSEST((xfer_size * 9) * 1000,
+ i2c_dev->bus_clk_rate);
tegra_i2c_flush_fifos(i2c_dev);
@@ -739,7 +753,7 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev,
i2c_readl(i2c_dev, I2C_INT_MASK));
time_left = wait_for_completion_timeout(&i2c_dev->msg_complete,
- TEGRA_I2C_TIMEOUT);
+ TEGRA_I2C_TIMEOUT(xfer_time));
tegra_i2c_mask_irq(i2c_dev, int_mask);
if (time_left == 0) {
--
2.7.4
next prev parent reply other threads:[~2019-01-26 3:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-26 3:57 [PATCH V3 1/3] i2c: tegra: Sort all the include headers alphabetically Sowjanya Komatineni
2019-01-26 3:57 ` Sowjanya Komatineni [this message]
2019-01-26 18:02 ` [PATCH V3 2/3] i2c: tegra: Update transfer timeout Dmitry Osipenko
2019-01-28 18:28 ` Sowjanya Komatineni
2019-01-28 22:08 ` Dmitry Osipenko
2019-01-28 22:15 ` Sowjanya Komatineni
2019-01-28 22:27 ` Dmitry Osipenko
2019-01-28 22:31 ` Sowjanya Komatineni
2019-01-29 10:15 ` Thierry Reding
2019-01-29 10:16 ` Thierry Reding
2019-01-29 11:21 ` Dmitry Osipenko
2019-01-26 3:57 ` [PATCH V3 3/3] i2c: tegra: Add DMA Support Sowjanya Komatineni
2019-01-26 17:11 ` Dmitry Osipenko
2019-01-26 18:16 ` Dmitry Osipenko
2019-01-26 17:29 ` Dmitry Osipenko
2019-01-26 20:42 ` Dmitry Osipenko
2019-01-26 21:24 ` Dmitry Osipenko
2019-01-28 23:47 ` Sowjanya Komatineni
2019-01-29 2:02 ` Sowjanya Komatineni
2019-01-29 3:11 ` Dmitry Osipenko
2019-01-26 17:29 ` [PATCH V3 1/3] i2c: tegra: Sort all the include headers alphabetically Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548475073-12408-2-git-send-email-skomatineni@nvidia.com \
--to=skomatineni@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkarthik@nvidia.com \
--cc=smohammed@nvidia.com \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).