Re: [PATCH v2 2/3] i2c: at91: fix clk_offset for sam9x60

Ludovic Desroches
2019-12-03T07:01:21Z

On Mon, Dec 02, 2019 at 10:01:17AM +0100, Eugen Hristev - M18282 wrote:
> From: Eugen Hristev <eugen.hristev@microchip.com>
>
> In SAM9X60 datasheet, FLEX_TWI_CWGR register rescription mentions clock

typo here: description

> offset of 3 cycles (compared to 4 in eg. SAMA5D3).
> This is the same offset as in SAMA5D2.
>
> Fixes: b00277923743 ("i2c: at91: add new platform support for sam9x60")
> Suggested-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>

Thanks

> ---
>
> Sorry, wrong subject line. Modified to SAM9X60 .
>
>
> drivers/i2c/busses/i2c-at91-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-at91-core.c b/drivers/i2c/busses/i2c-at91-core.c
> index e13af48..5137e62 100644
> --- a/drivers/i2c/busses/i2c-at91-core.c
> +++ b/drivers/i2c/busses/i2c-at91-core.c
> @@ -174,7 +174,7 @@ static struct at91_twi_pdata sama5d2_config = {
>
> static struct at91_twi_pdata sam9x60_config = {
> .clk_max_div = 7,
> - .clk_offset = 4,
> + .clk_offset = 3,
> .has_unre_flag = true,
> .has_alt_cmd = true,
> .has_hold_field = true,
> --
> 2.7.4
>