From: Sowjanya Komatineni <skomatineni@nvidia.com>
To: <skomatineni@nvidia.com>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <frankc@nvidia.com>, <hverkuil@xs4all.nl>,
<sakari.ailus@iki.fi>, <robh+dt@kernel.org>,
<helen.koike@collabora.com>
Cc: <digetx@gmail.com>, <sboyd@kernel.org>,
<gregkh@linuxfoundation.org>, <linux-media@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-i2c@vger.kernel.org>
Subject: [RFC PATCH v3 14/18] gpu: host1x: mipi: Update tegra_mipi_request() to be node based
Date: Tue, 14 Jul 2020 21:20:51 -0700 [thread overview]
Message-ID: <1594786855-26506-15-git-send-email-skomatineni@nvidia.com> (raw)
In-Reply-To: <1594786855-26506-1-git-send-email-skomatineni@nvidia.com>
Tegra CSI driver need a separate MIPI device for each channel as
calibration of corresponding MIPI pads for each channel should
happen independently.
So, this patch updates tegra_mipi_request() API to add a device_node
pointer argument to allow creating mipi device for specific device
node rather than a device.
Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
---
drivers/gpu/drm/tegra/dsi.c | 2 +-
drivers/gpu/host1x/mipi.c | 4 ++--
include/linux/host1x.h | 3 ++-
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c
index 38beab9..3c09e29 100644
--- a/drivers/gpu/drm/tegra/dsi.c
+++ b/drivers/gpu/drm/tegra/dsi.c
@@ -1618,7 +1618,7 @@ static int tegra_dsi_probe(struct platform_device *pdev)
if (IS_ERR(dsi->regs))
return PTR_ERR(dsi->regs);
- dsi->mipi = tegra_mipi_request(&pdev->dev);
+ dsi->mipi = tegra_mipi_request(&pdev->dev, pdev->dev.of_node);
if (IS_ERR(dsi->mipi))
return PTR_ERR(dsi->mipi);
diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c
index e00809d..762d349 100644
--- a/drivers/gpu/host1x/mipi.c
+++ b/drivers/gpu/host1x/mipi.c
@@ -206,9 +206,9 @@ static int tegra_mipi_power_down(struct tegra_mipi *mipi)
return 0;
}
-struct tegra_mipi_device *tegra_mipi_request(struct device *device)
+struct tegra_mipi_device *tegra_mipi_request(struct device *device,
+ struct device_node *np)
{
- struct device_node *np = device->of_node;
struct tegra_mipi_device *dev;
struct of_phandle_args args;
int err;
diff --git a/include/linux/host1x.h b/include/linux/host1x.h
index a3a568b..9e67841 100644
--- a/include/linux/host1x.h
+++ b/include/linux/host1x.h
@@ -328,7 +328,8 @@ int host1x_client_resume(struct host1x_client *client);
struct tegra_mipi_device;
-struct tegra_mipi_device *tegra_mipi_request(struct device *device);
+struct tegra_mipi_device *tegra_mipi_request(struct device *device,
+ struct device_node *np);
void tegra_mipi_free(struct tegra_mipi_device *device);
int tegra_mipi_enable(struct tegra_mipi_device *device);
int tegra_mipi_disable(struct tegra_mipi_device *device);
--
2.7.4
next prev parent reply other threads:[~2020-07-15 4:20 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 4:20 [RFC PATCH v3 00/18] Support for Tegra video capture from external sensor Sowjanya Komatineni
2020-07-15 4:20 ` [RFC PATCH v3 01/18] dt-bindings: i2c: tegra: Document Tegra210 VI I2C clocks and power-domains Sowjanya Komatineni
2020-07-16 13:25 ` Thierry Reding
2020-07-15 4:20 ` [RFC PATCH v3 02/18] arm64: tegra: Add missing clocks and power-domains to Tegra210 VI I2C Sowjanya Komatineni
2020-07-16 13:25 ` Thierry Reding
2020-07-15 4:20 ` [RFC PATCH v3 03/18] i2c: tegra: Don't mark VI I2C as IRQ safe runtime PM Sowjanya Komatineni
2020-07-15 4:20 ` [RFC PATCH v3 04/18] i2c: tegra: Remove NULL pointer check before clk_enable/disable/prepare/unprepare Sowjanya Komatineni
2020-07-16 20:25 ` Dmitry Osipenko
2020-07-15 4:20 ` [RFC PATCH v3 05/18] i2c: tegra: Fix the error path in tegra_i2c_runtime_resume Sowjanya Komatineni
2020-07-15 4:20 ` [RFC PATCH v3 06/18] i2c: tegra: Fix runtime resume to re-init VI I2C Sowjanya Komatineni
2020-07-15 4:20 ` [RFC PATCH v3 07/18] i2c: tegra: Avoid tegra_i2c_init_dma() for Tegra210 vi i2c Sowjanya Komatineni
2020-07-15 4:20 ` [RFC PATCH v3 08/18] media: tegra-video: Fix channel format alignment Sowjanya Komatineni
2020-07-15 4:20 ` [RFC PATCH v3 09/18] media: tegra-video: Enable TPG based on kernel config Sowjanya Komatineni
2020-07-15 4:20 ` [RFC PATCH v3 10/18] media: tegra-video: Update format lookup to offset based Sowjanya Komatineni
2020-07-15 4:20 ` [RFC PATCH v3 11/18] dt-bindings: tegra: Update VI and CSI bindings with port info Sowjanya Komatineni
2020-07-16 19:09 ` Rob Herring
2020-07-15 4:20 ` [RFC PATCH v3 12/18] media: tegra-video: Add support for external sensor capture Sowjanya Komatineni
2020-07-15 4:20 ` [RFC PATCH v3 13/18] media: tegra-video: Add support for selection ioctl ops Sowjanya Komatineni
2020-07-15 4:20 ` Sowjanya Komatineni [this message]
2020-07-16 20:26 ` [RFC PATCH v3 14/18] gpu: host1x: mipi: Update tegra_mipi_request() to be node based Dmitry Osipenko
2020-07-15 4:20 ` [RFC PATCH v3 15/18] gpu: host1x: mipi: Use readl_relaxed_poll_timeout in tegra_mipi_wait Sowjanya Komatineni
2020-07-15 4:20 ` [RFC PATCH v3 16/18] gpu: host1x: mipi: Split tegra_mipi_calibrate and tegra_mipi_wait Sowjanya Komatineni
2020-07-16 20:38 ` Dmitry Osipenko
2020-07-16 21:09 ` Sowjanya Komatineni
2020-07-16 21:18 ` Dmitry Osipenko
2020-07-16 22:49 ` Sowjanya Komatineni
2020-07-16 23:01 ` Dmitry Osipenko
2020-07-16 23:06 ` Sowjanya Komatineni
2020-07-16 23:09 ` Sowjanya Komatineni
2020-07-16 23:47 ` Dmitry Osipenko
2020-07-17 0:16 ` Sowjanya Komatineni
2020-07-17 4:46 ` Sowjanya Komatineni
2020-07-17 15:01 ` Dmitry Osipenko
2020-07-17 15:41 ` Sowjanya Komatineni
2020-07-17 20:14 ` Dmitry Osipenko
2020-07-15 4:20 ` [RFC PATCH v3 17/18] media: tegra-video: Add CSI MIPI pads calibration Sowjanya Komatineni
2020-07-15 4:20 ` [RFC PATCH v3 18/18] media: tegra-video: Compute settle times based on the clock rate Sowjanya Komatineni
2020-07-17 10:54 ` [RFC PATCH v3 00/18] Support for Tegra video capture from external sensor Hans Verkuil
2020-07-17 16:34 ` Sowjanya Komatineni
2020-07-17 17:08 ` Hans Verkuil
2020-07-17 17:23 ` Sowjanya Komatineni
2020-07-17 17:38 ` Sowjanya Komatineni
2020-07-17 17:48 ` Sowjanya Komatineni
2020-07-20 4:41 ` Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594786855-26506-15-git-send-email-skomatineni@nvidia.com \
--to=skomatineni@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=frankc@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).