From: Qii Wang <qii.wang@mediatek.com>
To: Xu Wang <vulab@iscas.ac.cn>
Cc: <Leilk.Liu@mediatek.com>, <matthias.bgg@gmail.com>,
<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: mediatek: remove redundant null check
Date: Mon, 26 Oct 2020 09:31:26 +0800 [thread overview]
Message-ID: <1603675886.25719.15.camel@mhfsdcap03> (raw)
In-Reply-To: <20200930084233.53085-1-vulab@iscas.ac.cn>
Thanks, it looks good for me, it would be better to remove all useless
members
On Wed, 2020-09-30 at 08:42 +0000, Xu Wang wrote:
> Because clk_disable_unprepare already checked NULL clock parameter,
> so the additional checks are unnecessary, just remove it
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> index 0cbdfbe605b5..48d37de827e1 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> @@ -449,8 +449,7 @@ static int mtk_i2c_clock_enable(struct mtk_i2c *i2c)
> return 0;
>
> err_arb:
> - if (i2c->have_pmic)
> - clk_disable_unprepare(i2c->clk_pmic);
> + clk_disable_unprepare(i2c->clk_pmic);
> err_pmic:
> clk_disable_unprepare(i2c->clk_main);
> err_main:
> @@ -461,11 +460,9 @@ static int mtk_i2c_clock_enable(struct mtk_i2c *i2c)
>
> static void mtk_i2c_clock_disable(struct mtk_i2c *i2c)
> {
> - if (i2c->clk_arb)
> - clk_disable_unprepare(i2c->clk_arb);
> + clk_disable_unprepare(i2c->clk_arb);
>
> - if (i2c->have_pmic)
> - clk_disable_unprepare(i2c->clk_pmic);
> + clk_disable_unprepare(i2c->clk_pmic);
>
> clk_disable_unprepare(i2c->clk_main);
> clk_disable_unprepare(i2c->clk_dma);
next prev parent reply other threads:[~2020-10-26 1:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 8:42 [PATCH] i2c: mediatek: remove redundant null check Xu Wang
2020-10-26 1:31 ` Qii Wang [this message]
2022-03-01 15:23 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1603675886.25719.15.camel@mhfsdcap03 \
--to=qii.wang@mediatek.com \
--cc=Leilk.Liu@mediatek.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).