From: Qii Wang <qii.wang@mediatek.com>
To: Ikjoon Jang <ikjn@chromium.org>
Cc: <wsa@the-dreams.de>, srv_heupstream <srv_heupstream@mediatek.com>,
<leilk.liu@mediatek.com>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>, <linux-i2c@vger.kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] i2c: mediatek: Get device clock-stretch time via dts
Date: Tue, 2 Mar 2021 20:32:11 +0800 [thread overview]
Message-ID: <1614688331.28437.7.camel@mhfsdcap03> (raw)
In-Reply-To: <CAATdQgCoLB-iOcxN2ptDmqD69FnyUen5XeRTq=LCCfXmWkBeWw@mail.gmail.com>
Hi,
On Tue, 2021-03-02 at 19:30 +0800, Ikjoon Jang wrote:
> Hi Qii,
> >
> > @@ -1171,6 +1173,8 @@ static int mtk_i2c_parse_dt(struct device_node *np, struct mtk_i2c *i2c)
> > if (i2c->clk_src_div == 0)
> > return -EINVAL;
> >
> > + of_property_read_u32(np, "clock-stretch-ns", &i2c->clock_stretch_ns);
> > +
>
> I think this new property "clock-stretch-ns" is for the same purpose of
> "i2c-scl-falling-time-ns" + "i2c-scl-rising-time-ns" defined in
> Documentation/devicetree/bindings/i2c/i2c.txt?
>
I haven't find the corresponding instructions;and this patch is for the
problem caused by clock-stretch when the scl is pulled.
> > i2c->have_pmic = of_property_read_bool(np, "mediatek,have-pmic");
> > i2c->use_push_pull =
> > of_property_read_bool(np, "mediatek,use-push-pull");
> > --
> > 1.9.1
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek
prev parent reply other threads:[~2021-03-03 1:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 10:35 [PATCH] i2c: mediatek: Get device clock-stretch time via dts qii.wang
2021-03-01 12:22 ` Qii Wang
2021-03-02 11:30 ` Ikjoon Jang
2021-03-02 12:32 ` Qii Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1614688331.28437.7.camel@mhfsdcap03 \
--to=qii.wang@mediatek.com \
--cc=ikjn@chromium.org \
--cc=leilk.liu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=srv_heupstream@mediatek.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).