* [PATCH] i2c: stm32f7: Remove useless error message
@ 2021-03-25 12:04 Tian Tao
2021-03-25 12:46 ` Alain Volmat
2021-03-31 7:58 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Tian Tao @ 2021-03-25 12:04 UTC (permalink / raw)
To: pierre-yves.mordret, alain.volmat, mcoquelin.stm32,
alexandre.torgue, p.zabel, sumit.semwal, christian.koenig
Cc: linux-i2c, linux-stm32, linux-arm-kernel
Fix the following coccicheck report:
drivers/i2c/busses/i2c-stm32f7.c:2032:3-10 : platform_get_irq :
line 2032 is redundant because platform_get_irq() already prints an error
Remove dev_err() messages after platform_get_irq() failures.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Signed-off-by: Zihao Tang <tangzihao1@hisilicon.com>
---
drivers/i2c/busses/i2c-stm32f7.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
index 162a3b0..9fbcbd1 100644
--- a/drivers/i2c/busses/i2c-stm32f7.c
+++ b/drivers/i2c/busses/i2c-stm32f7.c
@@ -2035,12 +2035,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
phy_addr = (dma_addr_t)res->start;
irq_event = platform_get_irq(pdev, 0);
- if (irq_event <= 0) {
- if (irq_event != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Failed to get IRQ event: %d\n",
- irq_event);
+ if (irq_event <= 0)
return irq_event ? : -ENOENT;
- }
irq_error = platform_get_irq(pdev, 1);
if (irq_error <= 0)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: stm32f7: Remove useless error message
2021-03-25 12:04 [PATCH] i2c: stm32f7: Remove useless error message Tian Tao
@ 2021-03-25 12:46 ` Alain Volmat
2021-03-31 7:58 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Alain Volmat @ 2021-03-25 12:46 UTC (permalink / raw)
To: Tian Tao
Cc: pierre-yves.mordret, mcoquelin.stm32, alexandre.torgue, p.zabel,
sumit.semwal, christian.koenig, linux-i2c, linux-stm32,
linux-arm-kernel
Hello,
Thanks for the patch.
Reviewed-by: Alain Volmat <alain.volmat@foss.st.com>
Alain
On Thu, Mar 25, 2021 at 08:04:32PM +0800, Tian Tao wrote:
> Fix the following coccicheck report:
>
> drivers/i2c/busses/i2c-stm32f7.c:2032:3-10 : platform_get_irq :
> line 2032 is redundant because platform_get_irq() already prints an error
>
> Remove dev_err() messages after platform_get_irq() failures.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> Signed-off-by: Zihao Tang <tangzihao1@hisilicon.com>
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index 162a3b0..9fbcbd1 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -2035,12 +2035,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
> phy_addr = (dma_addr_t)res->start;
>
> irq_event = platform_get_irq(pdev, 0);
> - if (irq_event <= 0) {
> - if (irq_event != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Failed to get IRQ event: %d\n",
> - irq_event);
> + if (irq_event <= 0)
> return irq_event ? : -ENOENT;
> - }
>
> irq_error = platform_get_irq(pdev, 1);
> if (irq_error <= 0)
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: stm32f7: Remove useless error message
2021-03-25 12:04 [PATCH] i2c: stm32f7: Remove useless error message Tian Tao
2021-03-25 12:46 ` Alain Volmat
@ 2021-03-31 7:58 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2021-03-31 7:58 UTC (permalink / raw)
To: Tian Tao
Cc: pierre-yves.mordret, alain.volmat, mcoquelin.stm32,
alexandre.torgue, p.zabel, sumit.semwal, christian.koenig,
linux-i2c, linux-stm32, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 461 bytes --]
On Thu, Mar 25, 2021 at 08:04:32PM +0800, Tian Tao wrote:
> Fix the following coccicheck report:
>
> drivers/i2c/busses/i2c-stm32f7.c:2032:3-10 : platform_get_irq :
> line 2032 is redundant because platform_get_irq() already prints an error
>
> Remove dev_err() messages after platform_get_irq() failures.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> Signed-off-by: Zihao Tang <tangzihao1@hisilicon.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-31 7:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-25 12:04 [PATCH] i2c: stm32f7: Remove useless error message Tian Tao
2021-03-25 12:46 ` Alain Volmat
2021-03-31 7:58 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).