From: Zou Wei <zou_wei@huawei.com>
To: <jdelvare@suse.com>
Cc: <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Zou Wei <zou_wei@huawei.com>
Subject: [PATCH -next] i2c: Fix missing pci_disable_device() on error in ali1535_setup()
Date: Mon, 7 Jun 2021 11:21:08 +0800 [thread overview]
Message-ID: <1623036068-30668-1-git-send-email-zou_wei@huawei.com> (raw)
Fix the missing pci_disable_device() before return
from ali1535_setup() in the error handling case.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/i2c/busses/i2c-ali1535.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-ali1535.c b/drivers/i2c/busses/i2c-ali1535.c
index fb93152..bdbaf79 100644
--- a/drivers/i2c/busses/i2c-ali1535.c
+++ b/drivers/i2c/busses/i2c-ali1535.c
@@ -206,6 +206,7 @@ static int ali1535_setup(struct pci_dev *dev)
exit_free:
release_region(ali1535_smba, ALI1535_SMB_IOSIZE);
exit:
+ pci_disable_device(dev);
return retval;
}
--
2.6.2
next reply other threads:[~2021-06-07 3:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 3:21 Zou Wei [this message]
2021-06-08 9:46 ` [PATCH -next] i2c: Fix missing pci_disable_device() on error in ali1535_setup() Jean Delvare
2021-06-08 11:30 ` Samuel Zou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623036068-30668-1-git-send-email-zou_wei@huawei.com \
--to=zou_wei@huawei.com \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).