From: Lars Poeschel <poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: viperboard: remove superfluous assignment
Date: Wed, 08 Jan 2014 18:00:34 +0100 [thread overview]
Message-ID: <1646720.ZFo3jWjium@lem-wkst-02> (raw)
In-Reply-To: <1388870493-6523-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
On Wednesday 08 January 2014 22:21:33, Wolfram Sang wrote:
> cppcheck rightfully says:
>
> drivers/i2c/busses/i2c-viperboard.c:169: style: Variable 'bytes_xfer' is
> assigned a value that is never used.
>
> Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
> ---
> drivers/i2c/busses/i2c-viperboard.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-viperboard.c
> b/drivers/i2c/busses/i2c-viperboard.c index 6976e1c..7533fa3 100644
> --- a/drivers/i2c/busses/i2c-viperboard.c
> +++ b/drivers/i2c/busses/i2c-viperboard.c
> @@ -118,8 +118,7 @@ static int vprbrd_i2c_addr(struct usb_device *usb_dev,
> static int vprbrd_i2c_read(struct vprbrd *vb, struct i2c_msg *msg)
> {
> int ret;
> - u16 remain_len, bytes_xfer, len1, len2,
> - start = 0x0000;
> + u16 remain_len, len1, len2, start = 0x0000;
> struct vprbrd_i2c_read_msg *rmsg =
> (struct vprbrd_i2c_read_msg *)vb->buf;
>
> @@ -166,7 +165,6 @@ static int vprbrd_i2c_read(struct vprbrd *vb, struct
> i2c_msg *msg) rmsg->header.len3 = remain_len - 512;
> rmsg->header.len4 = 0x00;
> rmsg->header.len5 = 0x00;
> - bytes_xfer = remain_len;
> remain_len = 0;
> } else if (remain_len <= 1022) {
> len1 = 512;
Acked-by: Lars Poeschel <poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public.gmane.org>
next prev parent reply other threads:[~2014-01-08 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-04 21:21 [PATCH] i2c: viperboard: remove superfluous assignment Wolfram Sang
[not found] ` <1388870493-6523-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-01-08 17:00 ` Lars Poeschel [this message]
2014-01-09 21:18 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1646720.ZFo3jWjium@lem-wkst-02 \
--to=poeschel-xtl8qvbwbhwb1svskn2v4q@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox