From: "Heiko Stübner" <heiko@sntech.de>
To: Addy Ke <addy.ke@rock-chips.com>
Cc: wsa@the-dreams.de, max.schwarz@online.de, olof@lixom.net,
dianders@chromium.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, cf@rock-chips.com,
xjq@rock-chips.com, huangtao@rock-chips.com, zyw@rock-chips.com,
yzq@rock-chips.com, hj@rock-chips.com, kever.yang@rock-chips.com,
hl@rock-chips.com, caesar.wang@rock-chips.com,
zhengsq@rock-chips.com
Subject: Re: [PATCH] i2c: rk3x: fix interrupt handling issue
Date: Fri, 08 Aug 2014 12:15:11 +0200 [thread overview]
Message-ID: <1676136.zY2YY7tt5d@diego> (raw)
In-Reply-To: <1407490900-4718-1-git-send-email-addy.ke@rock-chips.com>
Am Freitag, 8. August 2014, 17:41:40 schrieb Addy Ke:
> If slave holds scl, I2C_IPD[7] will be set 1 by controller
> for debugging. Driver must ignore it.
>
> [ 5.752391] rk3x-i2c ff160000.i2c: unexpected irq in WRITE: 0x80
> [ 5.939027] rk3x-i2c ff160000.i2c: timeout, ipd: 0x80, state: 4
>
> Signed-off-by: Addy Ke <addy.ke@rock-chips.com>
I checked the manuals, bits [31:7] are marked as reserved in all of them, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/i2c/busses/i2c-rk3x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> index 9e3084c..eab49e6 100644
> --- a/drivers/i2c/busses/i2c-rk3x.c
> +++ b/drivers/i2c/busses/i2c-rk3x.c
> @@ -399,7 +399,7 @@ static irqreturn_t rk3x_i2c_irq(int irqno, void *dev_id)
> }
>
> /* is there anything left to handle? */
> - if (unlikely(ipd == 0))
> + if (unlikely((ipd & REG_INT_ALL) == 0))
> goto out;
>
> switch (i2c->state) {
next prev parent reply other threads:[~2014-08-08 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 9:41 [PATCH] i2c: rk3x: fix interrupt handling issue Addy Ke
2014-08-08 10:15 ` Heiko Stübner [this message]
2014-08-08 16:34 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1676136.zY2YY7tt5d@diego \
--to=heiko@sntech.de \
--cc=addy.ke@rock-chips.com \
--cc=caesar.wang@rock-chips.com \
--cc=cf@rock-chips.com \
--cc=dianders@chromium.org \
--cc=hj@rock-chips.com \
--cc=hl@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max.schwarz@online.de \
--cc=olof@lixom.net \
--cc=wsa@the-dreams.de \
--cc=xjq@rock-chips.com \
--cc=yzq@rock-chips.com \
--cc=zhengsq@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).