From: Rob Herring <robh@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: devicetree@vger.kernel.org, Wolfram Sang <wsa@kernel.org>,
Shubhrajyoti Datta <Shubhrajyoti.datta@amd.com>,
Rob Herring <robh+dt@kernel.org>,
Michal Simek <michal.simek@amd.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: i2c: cadence: Document `fifo-depth` property
Date: Tue, 21 Mar 2023 15:20:45 -0500 [thread overview]
Message-ID: <167943004465.1499409.2418312435112481551.robh@kernel.org> (raw)
In-Reply-To: <20230317145441.156880-1-lars@metafoo.de>
On Fri, 17 Mar 2023 07:54:39 -0700, Lars-Peter Clausen wrote:
> The depth of the FIFO of the Cadence I2C controller IP is a synthesis
> configuration parameter. Different instances of the IP can have different
> values. For correct operation software needs to be aware of the size of the
> FIFO.
>
> Add the documentation for the devicetree property that describes the FIFO
> depth of the IP core.
>
> The default value of 16 is for backwards compatibility reasons with
> existing hardware descriptions where this property is not specified and
> software has assumed that the FIFO depth is 16.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> Changes since v1:
> * Remove quotes around "/schemas/types.yaml#/definitions/uint32"
> * Add `enum` describing valid values
> * Use `fifo-depth` instead of `cdns,fifo-depth`
> * Use `bytes` instead of `words` for the property unit
> ---
> Documentation/devicetree/bindings/i2c/cdns,i2c-r1p10.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2023-03-21 20:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 14:54 [PATCH v2 1/3] dt-bindings: i2c: cadence: Document `fifo-depth` property Lars-Peter Clausen
2023-03-17 14:54 ` [PATCH v2 2/3] i2c: cadence: Allow to specify the FIFO depth Lars-Peter Clausen
2023-03-20 10:11 ` Michal Simek
2023-03-29 19:19 ` Wolfram Sang
2023-03-17 14:54 ` [PATCH v2 3/3] i2c: cadence: Detect maximum transfer size Lars-Peter Clausen
2023-03-20 10:13 ` Michal Simek
2023-03-29 19:19 ` Wolfram Sang
2023-03-20 10:13 ` [PATCH v2 1/3] dt-bindings: i2c: cadence: Document `fifo-depth` property Michal Simek
2023-03-21 20:20 ` Rob Herring [this message]
2023-03-29 19:19 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167943004465.1499409.2418312435112481551.robh@kernel.org \
--to=robh@kernel.org \
--cc=Shubhrajyoti.datta@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-i2c@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=robh+dt@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox