RE: [PATCH v11 2/4] i2c: Add support for Intel LJCA USB I2C driver

Wu, Wentong
2023-08-30T20:15:54Z

Hi Wolfrma,

Thanks for your help

> From: Wolfram Sang <wsa@kernel.org>
>
> On Tue, Aug 29, 2023 at 12:54:06PM +0800, Wentong Wu wrote:
> > Implements the I2C function of Intel USB-I2C/GPIO/SPI adapter device
> > named "La Jolla Cove Adapter" (LJCA). It communicate with LJCA I2C
> > module with specific protocol through interfaces exported by LJCA USB
> > driver.
> >
> > Signed-off-by: Wentong Wu <wentong.wu@intel.com>
> > Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
>
> Basically good...
>
> > + if (ret < 0 || ret < sizeof(*r_packet)) {
> > + dev_err(&ljca_i2c->adap.dev,
> > + "i2c stop failed ret: %d id: %d\n",
> > + ret, w_packet->id);
>
> This was forgotten to be turned into dev_dbg. I could fix it while applying.

Thanks.

> But shall I take this patch via i2c?

Yes, please help merge this i2c-ljca patch via i2c tree, thanks

> I'd assume the dependencies are hidden away by auxiliary_bus

Exactly, thanks

BR,
Wentong