Re: [PATCH v12 4/4] gpio: update Intel LJCA USB GPIO driver

Andi Shyti
2023-09-01T15:19:09Z

Hi Wentong,

On Fri, Sep 01, 2023 at 01:36:17PM +0800, Wentong Wu wrote:
> This driver communicate with LJCA GPIO module with specific
> protocol through interfaces exported by LJCA USB driver.
> Update the driver according to LJCA USB driver's changes.
>
> Signed-off-by: Wentong Wu <wentong.wu@intel.com>
> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

I am not understanding this patch... Looks like a collection of
random to relevant changes you did in gpio-ljca.c.

I'm not able to review this, can you please split it in minor
changes?

Meanwhile the previous patches should be able to work without
this one, right?

Andi