RE: [PATCH v17 3/4] spi: Add support for Intel LJCA USB SPI driver

Wu, Wentong
2023-09-16T18:57:15Z

> From: Hans de Goede
>
> Hi Wentong,
>
> On 9/14/23 14:45, Wentong Wu wrote:
> > Implements the SPI function of Intel USB-I2C/GPIO/SPI adapter device
> > named "La Jolla Cove Adapter" (LJCA). It communicate with LJCA SPI
> > module with specific protocol through interfaces exported by LJCA USB
> > driver.
> >
> > Signed-off-by: Wentong Wu <wentong.wu@intel.com>
> > Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
> > Tested-by: Hans de Goede <hdegoede@redhat.com>
> > ---
> > drivers/spi/Kconfig | 11 ++
> > drivers/spi/Makefile | 1 +
> > drivers/spi/spi-ljca.c | 297
> > +++++++++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 309 insertions(+)
> > create mode 100644 drivers/spi/spi-ljca.c
> >
> > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index
> > 8962b25..ad18864 100644
> > --- a/drivers/spi/Kconfig
> > +++ b/drivers/spi/Kconfig
> > @@ -583,6 +583,17 @@ config SPI_FSL_ESPI
> > From MPC8536, 85xx platform uses the controller, and all P10xx,
> > P20xx, P30xx,P40xx, P50xx uses this controller.
> >
> > +config SPI_LJCA
> > + tristate "Intel La Jolla Cove Adapter SPI support"
> > + depends on USB_LJCA
> > + default USB_LJCA
> > + help
> > + Select this option to enable SPI driver for the Intel
> > + La Jolla Cove Adapter (LJCA) board.
> > +
> > + This driver can also be built as a module. If so, the module
> > + will be called spi-ljca.
> > +
> > config SPI_MESON_SPICC
> > tristate "Amlogic Meson SPICC controller"
> > depends on COMMON_CLK
> > diff --git a/drivers/spi/Makefile b/drivers/spi/Makefile index
> > 080c2c1..0847962 100644
> > --- a/drivers/spi/Makefile
> > +++ b/drivers/spi/Makefile
> > @@ -70,6 +70,7 @@ obj-$(CONFIG_SPI_INTEL_PCI) += spi-intel-
> pci.o
> > obj-$(CONFIG_SPI_INTEL_PLATFORM) += spi-intel-platform.o
> > obj-$(CONFIG_SPI_LANTIQ_SSC) += spi-lantiq-ssc.o
> > obj-$(CONFIG_SPI_JCORE) += spi-jcore.o
> > +obj-$(CONFIG_SPI_LJCA) += spi-ljca.o
> > obj-$(CONFIG_SPI_LM70_LLP) += spi-lm70llp.o
> > obj-$(CONFIG_SPI_LP8841_RTC) += spi-lp8841-rtc.o
> > obj-$(CONFIG_SPI_MESON_SPICC) += spi-meson-spicc.o
>
> I don't know what you are using as a base commit for these patches, but this
> does not apply cleanly on top of v6.6-rc1.
>
> For the next version of these patches please rebases this on top of v6.6-rc1; or
> on Linus' master branch.
>

Thanks, v17 is based on 6.5-rc4, now v19 is based on Linus' master branch.

BR,
Wentong

> Regards,
>
> Hans