From: Rob Herring <robh@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: konrad.dybcio@linaro.org, andi.shyti@kernel.org,
mchehab@kernel.org, conor+dt@kernel.org,
linux-i2c@vger.kernel.org, andersson@kernel.org,
linux-media@vger.kernel.org, rfoss@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
loic.poulain@linaro.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, todor.too@gmail.com,
agross@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 4/5] media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding
Date: Fri, 06 Oct 2023 08:58:51 -0500 [thread overview]
Message-ID: <169660073123.3776792.1207909917818505118.robh@kernel.org> (raw)
In-Reply-To: <20231006120159.3413789-5-bryan.odonoghue@linaro.org>
On Fri, 06 Oct 2023 13:01:58 +0100, Bryan O'Donoghue wrote:
> Add bindings for qcom,sc8280xp-camss in order to support the camera
> subsystem for sc8280xp as found in the Lenovo x13s Laptop.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../bindings/media/qcom,sc8280xp-camss.yaml | 598 ++++++++++++++++++
> 1 file changed, 598 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml: properties:power-domain-names:items: 'oneOf' conditional failed, one must be fixed:
[{'description': 'ife0'}, {'description': 'ife1'}, {'description': 'ife2'}, {'description': 'ife3'}, {'description': 'top'}] is not of type 'object'
Additional properties are not allowed ('description' was unexpected)
from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#
Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.example.dts:26:18: fatal error: dt-bindings/clock/qcom,sc8280xp-camcc.h: No such file or directory
26 | #include <dt-bindings/clock/qcom,sc8280xp-camcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1427: dt_binding_check] Error 2
make: *** [Makefile:234: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231006120159.3413789-5-bryan.odonoghue@linaro.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-10-06 13:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 12:01 [PATCH 0/5] Add sc8280xp CCI and CAMSS core dtsi Bryan O'Donoghue
2023-10-06 12:01 ` [PATCH 1/5] dt-bindings: i2c: qcom-cci: Document sc8280xp compatible Bryan O'Donoghue
2023-10-06 12:29 ` Krzysztof Kozlowski
2023-10-10 19:44 ` Wolfram Sang
2023-10-10 22:25 ` Bryan O'Donoghue
2023-10-11 6:28 ` Wolfram Sang
2023-10-06 12:01 ` [PATCH 2/5] i2c: qcom-cci: Add " Bryan O'Donoghue
2023-10-06 23:21 ` Konrad Dybcio
2023-10-08 21:28 ` Andi Shyti
2023-10-08 22:13 ` Bryan O'Donoghue
2023-10-08 22:26 ` Bryan O'Donoghue
2023-10-09 10:16 ` Konrad Dybcio
2023-10-06 12:01 ` [PATCH 3/5] arm64: dts: qcom: sc8280xp: camss: Add CCI definitions Bryan O'Donoghue
2023-10-06 12:01 ` [PATCH 4/5] media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding Bryan O'Donoghue
2023-10-06 12:33 ` Krzysztof Kozlowski
2023-10-06 12:52 ` Bryan O'Donoghue
2023-10-06 13:42 ` Krzysztof Kozlowski
2023-10-06 15:12 ` Rob Herring
2023-10-06 13:58 ` Rob Herring [this message]
2023-10-06 12:01 ` [PATCH 5/5] arm64: dts: qcom: sc8280xp: camss: Add CAMSS block definition Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169660073123.3776792.1207909917818505118.robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh+dt@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox