From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A85B3B7B8; Fri, 10 Nov 2023 20:41:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A35A185; Fri, 10 Nov 2023 12:41:12 -0800 (PST) Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-1efb9571b13so1413494fac.2; Fri, 10 Nov 2023 12:41:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699648872; x=1700253672; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sBu9jdlI8BmMP2EXqok2V/jfQ0F843VqKLKqoYajCbY=; b=m588BxKJH2+Ck7tJHFVuhHesrjOL7NXifPvZ5HJ/+NrTu46HyN9ZF9U5l5gvAPXP2z BsLTMezjPZpxoNj068XW5bjM53tahxDzu8rFk/bDgjFfodfUoSFucCOr29p/Pjf9aohN SEI6GtHU2J64DoafDoh0hl09zG1PPt9ZvAyQyvJTXM5rtUhQjwpCRy72kijLyOiqat0B 3X9jwgisFSx+oakRyahOj25jPCxITuzw7dnOxcge4oU/wSpfdBNoDRN2mq53bgCuciyG YPDKW+pTlor65WHkNdaotCfgvZuIUwPPQxc8f38qR7Bri9smbJ/7Kb99ZMllBuI7Y+bg BbCw== X-Gm-Message-State: AOJu0YxcuWT8Yng+/etxztdih/HsrkhY49gyrUmQxR0Wl48Vnks7ZFOe whF69/tp/e723/EnulHLkQ== X-Google-Smtp-Source: AGHT+IE7LNnk5DWomU2D9t+1ZTG+6ik+KpyphzRkzXtQujj9+w3A1KWUmfC2t3Snd6+6Q7shaSdaiw== X-Received: by 2002:a05:6870:c986:b0:1d5:40df:8fb1 with SMTP id hi6-20020a056870c98600b001d540df8fb1mr335335oab.19.1699648871913; Fri, 10 Nov 2023 12:41:11 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id mo37-20020a056871322500b001cd1a628c40sm57032oac.52.2023.11.10.12.41.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 12:41:11 -0800 (PST) Received: (nullmailer pid 395219 invoked by uid 1000); Fri, 10 Nov 2023 20:41:09 -0000 Date: Fri, 10 Nov 2023 14:41:09 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Jaehoon Chung , Jonathan Cameron , linux-rtc@vger.kernel.org, Alessandro Zummo , Sam Protsenko , Ulf Hansson , linux-pwm@vger.kernel.org, Krzysztof Kozlowski , dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Mark Brown , Lee Jones , Jiri Slaby , linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, Conor Dooley , Alexandre Belloni , Greg Kroah-Hartman , David Airlie , Tomasz Figa , Alim Akhtar , linux-arm-kernel@lists.infradead.org, =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , linux-sound@vger.kernel.org, Thomas Zimmermann , linux-samsung-soc@vger.kernel.org, Rob Herring , Daniel Vetter , Andi Shyti , linux-kernel@vger.kernel.org, Maxime Ripard , Thierry Reding , linux-iio@vger.kernel.org, Maarten Lankhorst , Lars-Peter Clausen , Sylwester Nawrocki , Liam Girdwood , Linus Walleij , linux-mmc@vger.kernel.org Subject: Re: [PATCH 07/17] dt-bindings: serial: samsung: add specific compatibles for existing SoC Message-ID: <169964886893.395180.18336203725841457804.robh@kernel.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-8-krzysztof.kozlowski@linaro.org> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231108104343.24192-8-krzysztof.kozlowski@linaro.org> On Wed, 08 Nov 2023 11:43:33 +0100, Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Re-shuffle also the entries in compatibles, so the one-compatible-enum > is the first. > > Signed-off-by: Krzysztof Kozlowski > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../devicetree/bindings/serial/samsung_uart.yaml | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > Acked-by: Rob Herring