public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: George Stark <gnstark@salutedevices.com>
Cc: rafael@kernel.org, krzk+dt@kernel.org, hkallweit1@gmail.com,
	 b.galvani@gmail.com, lukasz.luba@arm.com, conor+dt@kernel.org,
	 rui.zhang@intel.com, broonie@kernel.org,
	devicetree@vger.kernel.org,  linux-pm@vger.kernel.org,
	neil.armstrong@linaro.org,  daniel.lezcano@linaro.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org, khilman@baylibre.com,
	 mmkurbanov@sberdevices.ru, linux-spi@vger.kernel.org,
	 martin.blumenstingl@googlemail.com, linux-i2c@vger.kernel.org,
	 jbrunet@baylibre.com, glaroque@baylibre.com,
	 linux-amlogic@lists.infradead.org, kernel@salutedevices.com
Subject: Re: [PATCH 1/4] dt-bindings: spi: amlogic,a1-spifc: make power-domains required
Date: Mon, 08 Jul 2024 15:48:15 -0600	[thread overview]
Message-ID: <172047529524.3973694.1825285851935530574.robh@kernel.org> (raw)
In-Reply-To: <20240708194808.1819185-2-gnstark@salutedevices.com>


On Mon, 08 Jul 2024 22:48:05 +0300, George Stark wrote:
> SPI Flash Controller has dedicated power domain so make the
> corresponding property required.
> 
> Signed-off-by: George Stark <gnstark@salutedevices.com>
> ---
>  Documentation/devicetree/bindings/spi/amlogic,a1-spifc.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/amlogic,a1-spifc.example.dtb: spi@fd000400: Unevaluated properties are not allowed ('power-domains' was unexpected)
	from schema $id: http://devicetree.org/schemas/spi/amlogic,a1-spifc.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240708194808.1819185-2-gnstark@salutedevices.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2024-07-08 21:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-08 19:48 [PATCH 0/4] amlogic SoC's power-domains fixes George Stark
2024-07-08 19:48 ` [PATCH 1/4] dt-bindings: spi: amlogic,a1-spifc: make power-domains required George Stark
2024-07-08 19:51   ` Krzysztof Kozlowski
2024-07-10 16:23     ` George Stark
2024-07-10 16:38       ` neil.armstrong
2024-07-08 21:48   ` Rob Herring (Arm) [this message]
2024-07-08 19:48 ` [PATCH 2/4] dt-bindings: i2c: amlogic,meson6-i2c: add optional power-domains George Stark
2024-07-09  8:56   ` neil.armstrong
2024-07-09 16:31   ` Rob Herring (Arm)
2024-07-08 19:48 ` [PATCH 3/4] dt-bindings: thermal: amlogic,thermal: add power-domains George Stark
2024-07-08 19:52   ` Krzysztof Kozlowski
2024-07-08 19:48 ` [PATCH 4/4] arm64: dts: meson: a1: bind power domain to temperature sensor George Stark
2024-07-09  8:53   ` neil.armstrong
2024-07-09  8:56 ` [PATCH 0/4] amlogic SoC's power-domains fixes neil.armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172047529524.3973694.1825285851935530574.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=b.galvani@gmail.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=glaroque@baylibre.com \
    --cc=gnstark@salutedevices.com \
    --cc=hkallweit1@gmail.com \
    --cc=jbrunet@baylibre.com \
    --cc=kernel@salutedevices.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=mmkurbanov@sberdevices.ru \
    --cc=neil.armstrong@linaro.org \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox