Re: [PATCH v3 1/7] dt-bindings: connector: add GE SUNH hotplug addon connector

Luca Ceresoli
2024-08-14T14:42:49Z

Hello Rob,

On Tue, 13 Aug 2024 09:19:01 -0600
Rob Herring <robh@kernel.org> wrote:

> On Fri, Aug 09, 2024 at 05:34:49PM +0200, Luca Ceresoli wrote:
> > Add bindings for the GE SUNH add-on connector. This is a physical,
> > hot-pluggable connector that allows to attach and detach at runtime an
> > add-on adding peripherals on non-discoverable busses.
>
> Overall, looks pretty good.

Thanks, I'm very glad it does.

> > + maxItems: 1
> > +
> > + nobus-devices:
>
> Just 'devices'.

Sure, simple enough.

> > + description:
> > + A container for devices not accessible via any data bus. Common use
> > + cases include fixed and GPIO regulators, simple video panels and LED
> > + or GPIO backlight devices. When not hot-pluggable, nodes such devices
> > + are children of the root node.
> > +
> > + This node should not be present in the connector description in the
> > + base device tree. It should be added by overlays along with a subnode
> > + per device.
> > +
> > + type: object
> > + additionalProperties: false
>
> The schema needs to work with the overlay applied too. 'true' is fine
> here.

Does additionalProperties apply to nodes as well? No properties are
supposed to be added inside this node, only nodes, so I'm not sure what
to do about additionalProperties.

Queued all other changes for v4.

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering