From: "Rob Herring (Arm)" <robh@kernel.org>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: "Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
linux-fbdev@vger.kernel.org,
"Dragan Cvetic" <dragan.cvetic@amd.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Derek Kiernan" <derek.kiernan@amd.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Robert Foss" <rfoss@kernel.org>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
linux-kernel@vger.kernel.org,
"Paul Kocialkowski" <contact@paulk.fr>,
linux-i2c@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Saravana Kannan" <saravanak@google.com>,
"Paul Kocialkowski" <paul.kocialkowski@bootlin.com>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Helge Deller" <deller@gmx.de>,
devicetree@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Hervé Codina" <herve.codina@bootlin.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Lee Jones" <lee@kernel.org>, "Arnd Bergmann" <arnd@arndb.de>
Subject: Re: [PATCH v4 1/8] dt-bindings: connector: add GE SUNH hotplug addon connector
Date: Tue, 17 Sep 2024 05:29:51 -0500 [thread overview]
Message-ID: <172656899099.2713363.6775764159513105143.robh@kernel.org> (raw)
In-Reply-To: <20240917-hotplug-drm-bridge-v4-1-bc4dfee61be6@bootlin.com>
On Tue, 17 Sep 2024 10:53:05 +0200, Luca Ceresoli wrote:
> Add bindings for the GE SUNH add-on connector. This is a physical,
> hot-pluggable connector that allows to attach and detach at runtime an
> add-on adding peripherals on non-discoverable busses.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
> ---
>
> Changed in v4:
> - rename 'nobus-devices' to 'devices'
> - use 'additionalProperties: true' for the 'devices' node (nodes are added
> by overlays)
> - document GPIO polarity
> - add '|' for descriptions to preserve line breaks
> - remove powergood-gpios (removed in hardware design)
> - Omit "/" node, not needed and cause of warnings
> - remove reference to v2 examples from example comment
> - remove unneeded "addon_connector" label from example
>
> Changed in v3:
> - change the layout to only add subnodes, not properties
> - add the 'nobus-devices' node description to hold devices not on any bus
> - add 'i2c-*' nodes for the I2C busses, using a i2c-parent phandle
> - and the 'dsi' node for the DSI bus
> - move the entire port@1 node to the overlay (not only the remote-endpoint
> property)
> - remove the overlay examples (Overlays in examples are not supported)
> - add more clarifying descriptions and comments for examples
> - some rewording
>
> This patch was added in v2.
> ---
> .../connector/ge,sunh-addon-connector.yaml | 177 +++++++++++++++++++++
> MAINTAINERS | 5 +
> 2 files changed, 182 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/connector/ge,sunh-addon-connector.example.dtb: addon-connector: Unevaluated properties are not allowed ('powergood-gpios' was unexpected)
from schema $id: http://devicetree.org/schemas/connector/ge,sunh-addon-connector.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240917-hotplug-drm-bridge-v4-1-bc4dfee61be6@bootlin.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-09-17 10:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 8:53 [PATCH v4 0/8] Add support for GE SUNH hot-pluggable connector Luca Ceresoli
2024-09-17 8:53 ` [PATCH v4 1/8] dt-bindings: connector: add GE SUNH hotplug addon connector Luca Ceresoli
2024-09-17 10:29 ` Rob Herring (Arm) [this message]
2024-09-17 14:54 ` Luca Ceresoli
2024-09-17 8:53 ` [PATCH v4 2/8] drm/bridge: allow bridges to be informed about added and removed bridges Luca Ceresoli
2024-09-17 8:53 ` [PATCH v4 3/8] drm/encoder: add drm_encoder_cleanup_from() Luca Ceresoli
2024-09-17 8:53 ` [PATCH v4 4/8] drm/bridge: hotplug-bridge: add driver to support hot-pluggable DSI bridges Luca Ceresoli
2024-09-24 15:42 ` Luca Ceresoli
2024-09-17 8:53 ` [PATCH v4 5/8] i2c: i2c-core-of: follow i2c-parent phandle to probe devices from added nodes Luca Ceresoli
2024-12-12 19:12 ` Sverdlin, Alexander
2024-12-13 11:28 ` Luca Ceresoli
2024-12-13 11:45 ` Sverdlin, Alexander
2024-09-17 8:53 ` [PATCH v4 6/8] backlight: led-backlight: add devlink to supplier LEDs Luca Ceresoli
2024-09-19 12:43 ` Daniel Thompson
2024-09-20 12:41 ` Luca Ceresoli
2025-05-19 15:16 ` Luca Ceresoli
2024-09-17 8:53 ` [PATCH RFC v4 7/8] driver core: devlink: do not unblock consumers without any drivers found Luca Ceresoli
2024-09-17 8:53 ` [PATCH v4 8/8] misc: add ge-addon-connector driver Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172656899099.2713363.6775764159513105143.robh@kernel.org \
--to=robh@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=contact@paulk.fr \
--cc=daniel.thompson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=derek.kiernan@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=herve.codina@bootlin.com \
--cc=jernej.skrabec@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=rafael@kernel.org \
--cc=rfoss@kernel.org \
--cc=saravanak@google.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tzimmermann@suse.de \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox