From: "Rob Herring (Arm)" <robh@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: krzk+dt@kernel.org, tsbogend@alpha.franken.de,
devicetree@vger.kernel.org, andi.shyti@kernel.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linux-i2c@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: i2c: Add RTL9300 I2C controller
Date: Fri, 20 Sep 2024 18:10:39 -0500 [thread overview]
Message-ID: <172687383994.9882.1653066305378740682.robh@kernel.org> (raw)
In-Reply-To: <20240920000930.1828086-2-chris.packham@alliedtelesis.co.nz>
On Fri, 20 Sep 2024 12:09:28 +1200, Chris Packham wrote:
> Add dtschema for the I2C controller on the RTL9300 SoC. The I2C
> controllers on this SoC are part of the "switch" block which is
> represented here as a syscon node. The SCL pins are dependent on the I2C
> controller (GPIO8 for the first controller, GPIO 17 for the second). The
> SDA pins can be assigned to either one of the I2C controllers (but not
> both).
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
>
> Notes:
> Changes in v2:
> - Use reg property for controller registers
> - Remove global-control-offset (will be hard coded in driver)
> - Integrated the multiplexing function. Child nodes now represent the
> available SDA lines
>
> .../bindings/i2c/realtek,rtl9300-i2c.yaml | 82 +++++++++++++++++++
> MAINTAINERS | 6 ++
> 2 files changed, 88 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/realtek,rtl9300-i2c.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/i2c/realtek,rtl9300-i2c.example.dtb: /example-0/switch@1b000000: failed to match any schema with compatible: ['realtek,rtl9302c-switch', 'syscon', 'simple-mfd']
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/realtek,rtl9300-i2c.example.dtb: i2c@36c: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'clock-frequency' were unexpected)
from schema $id: http://devicetree.org/schemas/i2c/realtek,rtl9300-i2c.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240920000930.1828086-2-chris.packham@alliedtelesis.co.nz
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-09-20 23:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 0:09 [PATCH v2 0/3] i2c: RTL9300 support Chris Packham
2024-09-20 0:09 ` [PATCH v2 1/3] dt-bindings: i2c: Add RTL9300 I2C controller Chris Packham
2024-09-20 23:10 ` Rob Herring (Arm) [this message]
2024-09-22 20:25 ` Krzysztof Kozlowski
2024-09-23 21:09 ` Chris Packham
2024-09-24 7:58 ` Krzysztof Kozlowski
2024-09-20 0:09 ` [PATCH v2 2/3] i2c: Add driver for the " Chris Packham
2024-09-20 0:09 ` [PATCH v2 3/3] mips: dts: realtek: Add I2C controllers Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172687383994.9882.1653066305378740682.robh@kernel.org \
--to=robh@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox