From: Ulrich Hecht <uli@fpond.eu>
To: Fabien Parent <fparent@baylibre.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: drinkcat@chromium.org, wsa@the-dreams.de, hsinyi@chromium.org,
matthias.bgg@gmail.com, tglx@linutronix.de,
qii.wang@mediatek.com
Subject: Re: [PATCH v2] i2c: i2c-mt65xx: fix NULL ptr dereference
Date: Wed, 2 Oct 2019 10:43:55 +0200 (CEST) [thread overview]
Message-ID: <1733244772.936156.1570005835848@webmail.strato.com> (raw)
In-Reply-To: <20190930152846.5062-1-fparent@baylibre.com>
> On September 30, 2019 at 5:28 PM Fabien Parent <fparent@baylibre.com> wrote:
>
>
> Since commit abf4923e97c3 ("i2c: mediatek: disable zero-length transfers
> for mt8183"), there is a NULL pointer dereference for all the SoCs
> that don't have any quirk. mtk_i2c_functionality is not checking that
> the quirks pointer is not NULL before starting to use it.
>
> This commit add a call to i2c_check_quirks which will check whether
> the quirks pointer is set, and if so will check if the IP has the
> NO_ZERO_LEN quirk.
>
> Fixes: abf4923e97c3 ("i2c: mediatek: disable zero-length transfers for mt8183")
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
Thank you! Tested successfully on Acer R13 Chromebook (mt8173).
Tested-by: Ulrich Hecht <uli@fpond.eu>
CU
Uli
prev parent reply other threads:[~2019-10-02 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 15:28 [PATCH v2] i2c: i2c-mt65xx: fix NULL ptr dereference Fabien Parent
2019-09-30 21:20 ` Cengiz Can
2019-09-30 23:26 ` Hsin-Yi Wang
2019-10-02 8:43 ` Ulrich Hecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1733244772.936156.1570005835848@webmail.strato.com \
--to=uli@fpond.eu \
--cc=drinkcat@chromium.org \
--cc=fparent@baylibre.com \
--cc=hsinyi@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=qii.wang@mediatek.com \
--cc=tglx@linutronix.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox