From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Locke Subject: Re: [PATCH v3 1/2] i2c: qup: Add device tree bindings information Date: Thu, 23 Jan 2014 13:11:50 -0600 Message-ID: <174308F1-FFD2-4CB3-AEA2-C423F90FB133@codeaurora.org> References: <1389999819-10648-1-git-send-email-bjorn.andersson@sonymobile.com> <1389999819-10648-2-git-send-email-bjorn.andersson@sonymobile.com> Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: Mark Rutland , "linux-doc@vger.kernel.org" , "linux-i2c@vger.kernel.org" , Matt Porter , Wolfram Sang , Bjorn Andersson , Grant Likely , James Ralston , "devicetree@vger.kernel.org" , "Ivan T. Ivanov" , Pawel Moll , Ian Campbell , linux-arm-msm , Rob Herring , Jean Delvare , Andy Shevchenko , "linux-arm-kernel@lists.infradead.org" , Bill Brown , Greg Kroah-Hartman , linux-k List-Id: linux-i2c@vger.kernel.org Rob, On Jan 20, 2014, at 8:10 AM, Rob Herring wrote: > On Fri, Jan 17, 2014 at 5:03 PM, Bjorn Andersson > wrote: >> From: "Ivan T. Ivanov" >> >> The Qualcomm Universal Peripherial (QUP) wraps I2C mini-core and >> provide input and output FIFO's for it. I2C controller can operate >> as master with supported bus speeds of 100Kbps and 400Kbps. >> >> Signed-off-by: Ivan T. Ivanov >> [bjorn: reformulated part of binding description and cleaned up example] >> Signed-off-by: Bjorn Andersson >> --- > > Patch history? > >> .../devicetree/bindings/i2c/qcom,i2c-qup.txt | 41 ++++++++++++++++++++++ >> 1 file changed, 41 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt >> >> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt >> new file mode 100644 >> index 0000000..a99711b >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt >> @@ -0,0 +1,41 @@ >> +Qualcomm Universal Peripheral (QUP) I2C controller >> + >> +Required properties: >> + - compatible: Should be "qcom,i2c-qup". > > Seems a bit generic. All versions of the IP are exactly the same? > "qcom,-i2c-qup" would be better. The QUP IP block is the same across chips. Its possible there could be different versions of the IP block but its pretty stable now. > >> + - reg: Should contain QUP register address and length. >> + - interrupts: Should contain I2C interrupt. >> + >> + - clocks: Should contain the core clock and the AHB clock. >> + - clock-names: Should be "core" for the core clock and "iface" for the >> + AHB clock. >> + >> + - #address-cells: Should be <1> Address cells for i2c device address >> + - #size-cells: Should be <0> as i2c addresses have no size component >> + >> +Optional properties: >> + - clock-frequency: Should specify the desired i2c bus clock frequency in Hz, >> + default is 100kHz if omitted. >> + >> +Child nodes should conform to i2c bus binding. >> + >> +Example: >> + >> + i2c2: i2c@f9924000 { >> + compatible = "qcom,i2c-qup"; >> + reg = <0xf9924000 0x1000>; >> + interrupts = <0 96 0>; >> + >> + clocks = <&gcc_blsp1_qup2_i2c_apps_clk>, <&gcc_blsp1_ahb_clk>; >> + clock-names = "core", "iface"; >> + >> + clock-frequency = <355000>; >> + >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + dummy@60 { >> + compatible = "dummy"; >> + reg = <0x60>; >> + }; >> + }; >> + >> -- >> 1.8.2.2 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation