Re: [PATCH v2 01/72] dt-bindings: media: Deprecate clock-frequency property for camera sensors

Laurent Pinchart
2025-08-13T08:42:07Z

On Tue, Aug 12, 2025 at 11:44:42PM -0500, Rob Herring (Arm) wrote:
>
> On Wed, 13 Aug 2025 00:45:09 +0300, Laurent Pinchart wrote:
> > Usage of the clock-frequency property for camera sensors is discouraged
> > in favour of using assigned-clock-rates (and assigned-clock-parents
> > where needed). Mark the property as deprecated.
> >
> > Update the examples accordingly. In DT examples where the sensor input
> > clock appears to come from a programmable clock generator, replace
> > clock-frequency by the assigned-clocks and assigned-clock-rates
> > properties. Otherwise, just drop clock-frequency.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> > ---
> > Changes since v1:
> >
> > - Adapt examples in bindings that reference sensors
> > ---
> > Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 6 ++++--
> > Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 7 +++++--
> > .../devicetree/bindings/media/i2c/ovti,ov02a10.yaml | 3 +--
> > .../devicetree/bindings/media/i2c/ovti,ov5645.yaml | 6 +++++-
> > .../devicetree/bindings/media/i2c/ovti,ov7251.yaml | 6 +++++-
> > .../devicetree/bindings/media/i2c/ovti,ov8856.yaml | 3 +--
> > .../devicetree/bindings/media/i2c/samsung,s5k5baf.yaml | 6 +++++-
> > .../devicetree/bindings/media/i2c/samsung,s5k6a3.yaml | 6 +++++-
> > .../devicetree/bindings/media/i2c/sony,imx290.yaml | 5 +++--
> > .../bindings/media/samsung,exynos4212-fimc-is.yaml | 4 ++--
> > Documentation/devicetree/bindings/media/samsung,fimc.yaml | 3 ++-
> > 11 files changed, 38 insertions(+), 17 deletions(-)
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.example.dtb: image-sensor@10 (samsung,s5k6a3): 'clocks' is a required property
> from schema $id: http://devicetree.org/schemas/media/i2c/samsung,s5k6a3.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.example.dtb: image-sensor@10 (samsung,s5k6a3): 'clocks' is a dependency of 'clock-names'
> from schema $id: http://devicetree.org/schemas/clock/clock.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.example.dtb: image-sensor@10 (samsung,s5k6a3): 'anyOf' conditional failed, one must be fixed:
> 'clocks' is a required property
> '#clock-cells' is a required property
> from schema $id: http://devicetree.org/schemas/clock/clock.yaml#

This is what I get for relying blindly on CI :-/ Sorry about that, I'll
fix it (and try to fix CI too).

> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250812214620.30425-2-laurent.pinchart@ideasonboard.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.