From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] ACPI / I2C: Use parent's ACPI_HANDLE() in acpi_i2c_register_devices() Date: Tue, 02 Apr 2013 14:44:51 +0200 Message-ID: <1781994.sa3Syq0Q4W@vostro.rjw.lan> References: <2966020.zlpeyGGUDW@vostro.rjw.lan> <20130402045105.GA17682@the-dreams.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20130402045105.GA17682-z923LK4zBo2bacvFa/9K2g@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: ACPI Devel Maling List , LKML , Mika Westerberg , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ben Dooks , Jean Delvare List-Id: linux-i2c@vger.kernel.org On Tuesday, April 02, 2013 06:52:37 AM Wolfram Sang wrote: > On Mon, Apr 01, 2013 at 02:25:03AM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > The ACPI handle of struct i2c_adapter's dev member should not be > > set, because this causes that struct i2c_adapter to be associated > > with the ACPI device node corresponding to its parent as the > > second "physical_device", which is incorrect (this happens during > > the registration of struct i2c_adapter). Consequently, > > acpi_i2c_register_devices() should use the ACPI handle of the > > parent of the struct i2c_adapter it is called for rather than the > > struct i2c_adapter's ACPI handle (which should be NULL). > > > > Make that happen and modify the i2c-designware-platdrv driver, > > which currently is the only driver for ACPI-enumerated I2C > > controller chips, not to set the ACPI handle for the > > struct i2c_adapter it creates. > > > > Signed-off-by: Rafael J. Wysocki > > Shall this go via the I2C tree? If not, for the I2C part: Well, I'm going to push it through the ACPI/PM tree, if that's not a problem along with an analogous SPI patch. > Acked-by: Wolfram Sang Thanks! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.