From: Tomasz Figa <tomasz.figa@gmail.com>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org,
Wolfram Sang <w.sang@pengutronix.de>,
Giridhar Maruthy <giridhar.m@samsung.com>
Subject: Re: [PATCH] i2c: s3c2410: Add quirk to exclude GPIO config for exynos5440
Date: Sat, 19 Jan 2013 11:52:44 +0100 [thread overview]
Message-ID: <1786045.3qNF5pjnvJ@flatron> (raw)
In-Reply-To: <1358572323-24486-1-git-send-email-kgene.kim@samsung.com>
Hi Kukjin,
You should also add the new compatible value to the documentation of
device tree bindings for i2c-s3c2410.
(Documentation/devicetree/bindings/i2c/i2c-s3c2410.txt)
Best regards,
Tomasz Figa
On Friday 18 of January 2013 21:12:03 Kukjin Kim wrote:
> From: Giridhar Maruthy <giridhar.m@samsung.com>
>
> Signed-off-by: Giridhar Maruthy <giridhar.m@samsung.com>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> drivers/i2c/busses/i2c-s3c2410.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c
> b/drivers/i2c/busses/i2c-s3c2410.c index a290d08..ec141b4 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -109,6 +109,8 @@ MODULE_DEVICE_TABLE(platform, s3c24xx_driver_ids);
> static const struct of_device_id s3c24xx_i2c_match[] = {
> { .compatible = "samsung,s3c2410-i2c", .data = (void *)0 },
> { .compatible = "samsung,s3c2440-i2c", .data = (void *)QUIRK_S3C2440
> }, + { .compatible = "samsung,exynos5440-i2c",
> + .data = (void *)(QUIRK_S3C2440 | QUIRK_NO_GPIO) },
> { .compatible = "samsung,s3c2440-hdmiphy-i2c",
> .data = (void *)(QUIRK_S3C2440 | QUIRK_HDMIPHY | QUIRK_NO_GPIO) },
> {},
next prev parent reply other threads:[~2013-01-19 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 5:12 [PATCH] i2c: s3c2410: Add quirk to exclude GPIO config for exynos5440 Kukjin Kim
2013-01-19 10:52 ` Tomasz Figa [this message]
2013-01-20 23:28 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1786045.3qNF5pjnvJ@flatron \
--to=tomasz.figa@gmail.com \
--cc=giridhar.m@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).