From: "Rob Herring (Arm)" <robh@kernel.org>
To: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
Cc: tomm.merciai@gmail.com, Andi Shyti <andi.shyti@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Magnus Damm <magnus.damm@gmail.com>,
Chris Brandt <chris.brandt@renesas.com>,
devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
biju.das.jz@bp.renesas.com
Subject: Re: [PATCH v2] dt-bindings: i2c: renesas,riic: Drop clock-frequency from required
Date: Tue, 11 Aug 2026 21:56:02 -0500 [thread overview]
Message-ID: <178650336197.631765.122141109682113788.robh@kernel.org> (raw)
In-Reply-To: <20260806111018.782380-1-tommaso.merciai.xr@bp.renesas.com>
On Thu, 06 Aug 2026 13:10:13 +0200, Tommaso Merciai wrote:
> clock-frequency is described as optional, with 100 kHz assumed when
> absent, yet it is also listed as required.
>
> The description is correct: i2c-riic calls i2c_parse_fw_timings() with
> use_defaults set, so the core falls back to I2C_MAX_STANDARD_MODE_FREQ
> when the property is absent.
>
> The stale requirement only produces dtbs_check noise on boards relying
> on the default:
>
> i2c@14400800 (renesas,riic-r9a09g047): 'clock-frequency' is a
> required property
>
> Drop it.
>
> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> ---
> v1->v2:
> - Dropped all v1 series, need a rework.
> - Fixed dtbs_check failure by dropping clock-frequency from the required list,
> instead of adding it to the dts, as the absence of this property
> indicates the default frequency 100 kHz.
> v1: https://lore.kernel.org/all/20260803132828.3249424-3-tommaso.merciai.xr@bp.renesas.com/
>
> Documentation/devicetree/bindings/i2c/renesas,riic.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
prev parent reply other threads:[~2026-08-12 2:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 11:10 [PATCH v2] dt-bindings: i2c: renesas,riic: Drop clock-frequency from required Tommaso Merciai
2026-08-06 12:16 ` Geert Uytterhoeven
2026-08-12 2:56 ` Rob Herring (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178650336197.631765.122141109682113788.robh@kernel.org \
--to=robh@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=chris.brandt@renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=tomm.merciai@gmail.com \
--cc=tommaso.merciai.xr@bp.renesas.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox