From: Dmitry Osipenko <digetx@gmail.com>
To: "Akhil R" <akhilrajeev@nvidia.com>,
"christian.koenig@amd.com" <christian.koenig@amd.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Laxman Dewangan" <ldewangan@nvidia.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"Mikko Perttunen" <mperttunen@nvidia.com>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"sumit.semwal@linaro.org" <sumit.semwal@linaro.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"Svyatoslav Ryhel" <clamor95@gmail.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Krishna Yarlagadda" <kyarlagadda@nvidia.com>
Subject: Re: [PATCH RESEND] i2c: tegra: Add SMBus block read function
Date: Wed, 16 Feb 2022 21:50:36 +0300 [thread overview]
Message-ID: <178fd94a-3e2f-2ad7-dd6b-92f8c97d76a1@gmail.com> (raw)
In-Reply-To: <DM5PR12MB1850AF583634853FB796581CC0359@DM5PR12MB1850.namprd12.prod.outlook.com>
16.02.2022 06:54, Akhil R пишет:
>> 14.02.2022 07:49, Akhil R пишет:
>>>> It's unclear to me what's the point of emulating
>>>> I2C_FUNC_SMBUS_READ_BLOCK_DATA within the driver if you could use
>>>> i2c_smbus_read_i2c_block_data().
>>> We are looking to support I2C_M_RECV_LEN where the length is read from
>>> the first byte of data. I see that i2c_smbus_read_i2c_block_data()
>>> requires the length to be passed from the client driver.
>>>
>>> BTW, I2C_FUNC_SMBUS_WRITE_BLOCK_DATA is also expected to be
>> supported.
>>> It is included in I2C_FUNC_SMBUS_EMUL. I suppose, it doesn't require
>>> any additional change in the driver. The client driver should populate
>>> the first byte as the length of data to be transferred.
>>
>> Please support both read and write.
> Both read and write are supported. Write doesn't require any additional
> change in the driver as far as I understand.
>
> It is actually the same that I mentioned before. Or am I missing something here?
I missed that I2C_FUNC_SMBUS_EMUL includes I2C_FUNC_SMBUS_WRITE_BLOCK_DATA.
next prev parent reply other threads:[~2022-02-16 18:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 15:36 [PATCH RESEND] i2c: tegra: Add SMBus block read function Akhil R
2022-02-10 20:25 ` Dmitry Osipenko
2022-02-11 9:11 ` Akhil R
2022-02-12 16:15 ` Dmitry Osipenko
2022-02-12 16:20 ` Dmitry Osipenko
2022-02-12 20:08 ` Dmitry Osipenko
2022-02-14 4:49 ` Akhil R
2022-02-15 21:33 ` Dmitry Osipenko
2022-02-16 3:54 ` Akhil R
2022-02-16 18:50 ` Dmitry Osipenko [this message]
2022-02-16 20:32 ` Dmitry Osipenko
2022-02-25 13:03 ` Thierry Reding
2022-03-01 19:37 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178fd94a-3e2f-2ad7-dd6b-92f8c97d76a1@gmail.com \
--to=digetx@gmail.com \
--cc=akhilrajeev@nvidia.com \
--cc=christian.koenig@amd.com \
--cc=clamor95@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mperttunen@nvidia.com \
--cc=p.zabel@pengutronix.de \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).