From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA0273932DB for ; Fri, 16 Oct 2026 02:40:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792118449; cv=none; b=AB1OmL0iQ9Nm6RtvZ5/tRFU5xdWaTS/IizgfSfE/ofT56tAO/eWnY9YcjiMUx19frBkLpMgGRCqYQyMMX0kONMTEPVRaONE+qL2mo/9Osr1X7HSFXXdkrLUvlK5jSxZ5Iw1MK6/+30UAWus53eDxIQ9fBKvJ1qks/T6InlZ/YAg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792118449; c=relaxed/simple; bh=gRW0CdjdsemactFwR3AGo+8wfuwlCISA/LqSdtKqkJM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CVxTQ47Q8YoTrotSOe/tBAEWf4Z9CZv6hbDrjpgDF/2Ki4r232wblXIzphztx+ijCjx9V/L0wYupa5lPoLmi+Q+0glxoJYkcFi4rQOEWkfzhaFqoAH7l2rj3H4A/28ieQShKVm98jnjTnnEF2frsowiK5dlX7MqgDVUKBNa6UNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IzVy0qPX; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IzVy0qPX" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2e812e2b31bso34711045ad.3 for ; Thu, 15 Oct 2026 19:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792118446; x=1792723246; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=KXXcWB8W/TzI98uT3k5P5pneThN/kTNcoObGZm/mG3c=; b=IzVy0qPX8DVeU9Eb8hGI0aR5d1UJxcwftCz6FPsBTLyKn9eu36BiKne9qYss3jJnHc jTQTaabqmbDpLXCmq6HIrfUCENVFb35qpwHQUTcwaxdS/T0ylMD8q8CcFJGyoaNqWV6l HU50KwQnw5SGyd8QgRym2HYR3IHsTqIZSv26aXDPVSP/rq55w8yHjOCDvFk6YcFTEUFR uo2quhW7UbFsl6T9ooHpPMBKw0QJ0lvqK0aGbgt5t19IdUzL69hmGy74jKfNPXzulgIn DRZf8/oLmnlG7EtbbLB1iK8hRsEkgDhzq1B4jFYMBz/SpcF8ElBZ5AhU5UkiyBheKvf1 kFZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792118446; x=1792723246; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=KXXcWB8W/TzI98uT3k5P5pneThN/kTNcoObGZm/mG3c=; b=LgJQoixAJ8NFtACNteU22k3vobmCkUhe+oqw3FfjUwfeeE0I+ZbzXiviBLD7mSfHBG yElFfUPLQQ0JArSJPV9lp6vqIX7VFA4G1GD1nU0I1Pm5WDKtEjFAtTL6cHw7Gt+kV69k FOANQ5YQQ3CmVhBQm7s70D2Scyv7fou3lPjWA3sPiAK0Z+PrRQmCrWmXMz1ulGsyValq 54zANKHrfqnQQ8biWjFy3PUWHhewak8cT/+W+zyspHJixyJy1EzQWgguxRlMst47y1cn rRJzzJQGGEOjDGmx/xKDtzIWmIwunXS2i3x65riHXRoRw13IdcSRchNwHF0J3HN2jWPd 4ZVA== X-Forwarded-Encrypted: i=1; AKwUvBzUU/plsQCC9zJX/bI5qUVVxRrMouk4IgldLlb+UFFCkJbiWoGlDxt0oRLY4d1qHbHf9yB6T+Rb1q4=@vger.kernel.org X-Gm-Message-State: AFq9FYImBzT+0+aP6h3GHz1kVo/UC22TUYqfa049Chva3ffjsnWeJUTW jPeRgQVIfUCrosN0S7uvj9cTHS7oWJeOGU6a17TpOTu+2W8zYAeIjtwC X-Gm-Gg: AYBFou3TVI1DBEhCjGrynPPc14LE78/iXwH11KdTEPXEI0FEGOShoYL1QD3+Z1NEOV3 Lfyj8wn5QgVuqQ4N9yCd0LFW/s+k0k2LjFc8YhYQkwd0+Lnil+2aJ0Aa++XGpYt/Xh7CEPd2Jde 3Y8aTiF1x3P8jBGVT1xC47kOfYT5VAPSfVVRednzqJBihWjgGPsKHEcXaXOKC9QbDI5dePbx7Wq pFVx2i4uV9ix9yD+v2IbpZR2JfKxk0kdDPTdj7eOArrUklupo3iJpYfsyXrJPOWGe73kQWxtcNh MI6t/etLrrm2VmiQYhG9ETM9AjH6FfWh7tb4k1qgq0bH3guhENJG1q2DJEEh4GKOZWzZFxkj5gz yck22KUgEg8DTXjW/BlL4RrhiLLFoAj5Gs/WjBj3s0BPvUg1j43E4cmcrom4gRs8GnLoaPaqPAK JWw7IiLFs4MH6pvb3/g0ILsiycu89iqx5iB36G07g7e+Xe9vXXw/6AYp+Afka9fKN3pZP/qMI3q enSyNRS9PxZlCqc8ltYgtraHJx9LRHXQnL8YjStq2b6ag== X-Received: by 2002:a17:902:fd8c:b0:2d6:f6ba:263d with SMTP id d9443c01a7336-2e948deee77mr57925175ad.7.1792118445794; Thu, 15 Oct 2026 19:40:45 -0700 (PDT) Received: from [172.19.1.48] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e97e804d2dsm3246715ad.17.2026.10.15.19.40.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2026 19:40:43 -0700 (PDT) Message-ID: <17bf5ca0-c071-4ba8-b168-3ffbdae629ad@gmail.com> Date: Fri, 16 Oct 2026 10:40:39 +0800 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 0/3] i2c: ma35d1: Add support for MA35D1 I2C controller To: Andi Shyti , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Jacky Huang , Shan-Chun Hung , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Andrew Jeffery References: <20261016010448.324856-1-zychennvt@gmail.com> Content-Language: en-US From: zychen In-Reply-To: <20261016010448.324856-1-zychennvt@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi all, Sorry, the cover letter subject contains a typo: it should be [PATCH v12 0/3], not [PATCH v11 0/3]. The cover letter content and all three patches are from v12. Sorry for the confusion. Best regards, Zi-Yu Zi-Yu Chen 於 2026/10/16 上午 09:04 寫道: > This series adds support for the I2C controller found in the Nuvoton > MA35D1 SoC. The driver supports controller and optional target mode > and runtime power management. > > The implementation has been tested on the Nuvoton MA35D1 SOM board. > > Signed-off-by: Zi-Yu Chen > --- > Changes in v12: > - Synchronize IRQs while initializing transfer state and issuing START. > - Clear wake-up control if enabling IRQ wake fails. > v11: https://lore.kernel.org/all/20261001075101.489660-1-zychennvt@gmail.com/ > > Changes in v11: > According to Andi's comments: > - Prefix the remaining timeout macros with `MA35_`. > - Handle errors returned by `i2c_slave_event()` by sending NACK when the > target driver rejects a request. > - Use `dev_err_probe()` consistently in probe error paths. > v10: https://lore.kernel.org/r/20260921083753.1109826-1-zychennvt@gmail.com/ > > Changes in v10: > - Handle enable_irq_wake() return value in suspend. > - Correct clock divider mask and maximum limit to 10-bit. > v9: https://lore.kernel.org/r/20260807060400.2047517-1-zychennvt@gmail.com/ > > Changes in v9: > - Centralize SI handling in the interrupt handler. > - Fix target mode comments. > - Initialize the target transmit byte. > - Add reset_control_deassert() during probe. > v8: https://lore.kernel.org/r/20260804084806.1846570-1-zychennvt@gmail.com/ > > Changes in v8: > - Remove rpm_put avoid duplicate processing. > - Add synchronize_irq wait for interrupt to finish before i2c->target = NULL. > - Add ma35d1_i2c_restore_idle() to handle bus errors or spurious interrupts. > - Change return types of TRX helper functions to irqreturn_t, returning > IRQ_NONE for unhandled status codes. > v7: https://lore.kernel.org/r/20260727081859.1737223-1-zychennvt@gmail.com/ > > Changes in v7: > - Disable IRQ before clearing i2c->msg. > - Support CONFIG_PM=n, and simplify runtime PM setup accordingly. > - Remove redundant register access in runtime suspend/resume callbacks. > - Defer clearing i2c->target until after pm_runtime_put_sync() in ma35d1_unreg_target(). > - Enable interrupts alongside I2C enable in ma35d1_i2c_reset(). > v6: https://lore.kernel.org/r/20260720030616.1067660-1-zychennvt@gmail.com/ > > Changes in v6: > - Patch 2 (driver): > - Removed dynamic IRQ toggling helpers for simpler interrupt management. > Based on Sashiko AI Feedback: > - Added zero-length read quirk. > - Set i2c->msg to NULL on timeout to avoid use-after-free. > - Cleared hardware registers on target unregistration to release the bus. > - Protected suspend-path register writes with a spinlock. > - Validated clock-frequency to prevent division-by-zero. > - Removed incorrect I2C_M_IGNORE_NAK handling. > - Corrected a comment typo in the receive data path. > - Patch 3 (dts): > - use a generic functional name audio-codec@1a > v5: https://lore.kernel.org/r/20260630012106.3616821-1-zychennvt@gmail.com/ > > Changes in v5: > - Patch 2 (driver): > - Add spinlock protection for MA35_CTL0 register access. > - Add NULL pointer check for i2c->msg in the ISR. > - Use devres-managed cleanup (devm_add_action_or_reset) for runtime PM. > - Use pm_runtime_force_suspend/resume() for Controller mode > system sleep. > - Control I2CEN bit enabling/disabling via runtime PM. > - Refactor arbitration lost handling in state machines. > - Remove unsupported I2C_FUNC_PROTOCOL_MANGLING flag. > - Clean up readl_poll_timeout() parameters, retry loop, and > unused macros. > v4: https://lore.kernel.org/r/20260610030208.2020275-1-zychennvt@gmail.com/ > > Changes in v4: > - Patch 1 (dt-bindings): > - Update example interrupt number. > - Patch 2 (driver): > - Remove redundant spinlocks and fix 'irq' type to signed. > - Fix target address recovery in ma35d1_i2c_reset(). > - Refactor IRQ handler for multi-msg reads and NACK/IGNORE_NAK. > - Fix timeout UAF via explicit IRQ disabling during recovery. > - Drop IRQF_SHARED and fix PM paths in probe/unregistration. > - Limit suspend/resume wakeup logic to target mode only. > - Patch 3 (dts): > - Add missing i2c0 node to dtsi. > - Switch SoM configuration from i2c1 to i2c2 with updated pinctrl. > - Add nau8822 audio codec node under i2c2 on the SoM board. > - Drop redundant i2c0 alias and clean up dtsi property ordering. > v3: https://lore.kernel.org/r/20260512073953.564323-1-zychennvt@gmail.com/ > > Changes in v3: > - Fix minor DTS formatting issues (whitespace, missing newline) > v2: https://lore.kernel.org/r/20260316063726.41048-1-zychennvt@gmail.com > > Changes in v2: > - Overall: > - Rebase on linux-i2c/i2c-next > - Switched terminology from "master/slave" to "controller/target". > - Patch 1 (dt-bindings): > - Simplified description and fixed 'reg' size in example. > - Patch 2 (driver): > - Modernized using devm_*, generic device properties, and FIELD_PREP/GENMASK. > - Optimized power management by moving clock control to runtime PM. > - Simplified code by removing redundant .remove(), .owner, and inlines. > - Added dev_err_probe() and default bus frequency handling. > - Patch 3 (dts): > - Moved i2c aliases to board dts and reordered nodes alphabetically. > v1: https://lore.kernel.org/r/20260302020822.13936-1-zychennvt@gmail.com > > Zi-Yu Chen (3): > dt-bindings: i2c: nuvoton,ma35d1-i2c: Add MA35D1 I2C controller > i2c: ma35d1: Add Nuvoton MA35D1 I2C driver support > arm64: dts: nuvoton: Add I2C nodes for MA35D1 SoC > > .../bindings/i2c/nuvoton,ma35d1-i2c.yaml | 63 ++ > .../boot/dts/nuvoton/ma35d1-som-256m.dts | 20 + > arch/arm64/boot/dts/nuvoton/ma35d1.dtsi | 72 ++ > drivers/i2c/busses/Kconfig | 13 + > drivers/i2c/busses/Makefile | 1 + > drivers/i2c/busses/i2c-ma35d1.c | 800 ++++++++++++++++++ > 6 files changed, 969 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/nuvoton,ma35d1-i2c.yaml > create mode 100644 drivers/i2c/busses/i2c-ma35d1.c >