From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa@kernel.org>, Jean Delvare <jdelvare@suse.com>,
linux-i2c@vger.kernel.org, Andi Shyti <andi.shyti@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/10] drivers/i2c/busses: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
Date: Thu, 23 Nov 2023 22:58:53 +0100 [thread overview]
Message-ID: <19d86ace-a0ea-41d4-82d7-e77ef79e58f7@gmail.com> (raw)
In-Reply-To: <ZV+8z7zloE/gn/4p@ninjato>
On 23.11.2023 21:57, Wolfram Sang wrote:
>
>> Series was created supported by Coccinelle and its splitpatch.
>
> I don't know splitpatch. However, I don't understand its result. Why
> isn't there one patch for all in drivers/i2c/busses? Also, the subject
> prefix should be plain "i2c: <do x for all drivers>" or something.
>
AFAIK splitpatch uses get_maintainer.pl and creates one patch per
maintainer(s). It's not smart enough to group changes per module.
What I see is that the subject prefix often is based on personal
preference of the subsystem maintainer, so far I don't see a rule.
Therefore splitpatch seems to use the longest common part of file
path's of grouped patches.
I'd appreciate hints on maybe better tools for creating patches for
tree-wide changes. If possible I'd like to avoid having to manually
split and adjust the patches.
next prev parent reply other threads:[~2023-11-23 21:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 18:04 [PATCH 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON Heiner Kallweit
2023-11-18 18:04 ` [PATCH 01/10] drivers/i2c/busses: " Heiner Kallweit
2023-11-23 20:57 ` Wolfram Sang
2023-11-23 21:58 ` Heiner Kallweit [this message]
2023-11-18 18:04 ` [PATCH 02/10] drivers/staging/greybus/i2c.c: " Heiner Kallweit
2023-11-23 12:47 ` Greg Kroah-Hartman
2023-11-18 18:04 ` [PATCH 03/10] drivers/i2c/busses/i2c-pasemi-pci.c: " Heiner Kallweit
2023-11-18 18:04 ` [PATCH 04/10] drivers/i2c/i2c-stub.c: " Heiner Kallweit
2023-11-18 18:04 ` [PATCH 05/10] drivers/i2c/busses: " Heiner Kallweit
2023-11-23 23:10 ` Peter Rosin
2023-11-24 10:09 ` Heiner Kallweit
2023-11-18 18:05 ` [PATCH 06/10] drivers/i2c/busses/i2c-gpio.c: " Heiner Kallweit
2023-11-18 18:05 ` [PATCH 07/10] drivers/i2c/busses/i2c-mlxcpld.c: " Heiner Kallweit
2023-11-18 18:05 ` [PATCH 08/10] drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c: " Heiner Kallweit
2023-11-23 20:55 ` Wolfram Sang
2023-11-24 10:15 ` Heiner Kallweit
2023-11-18 18:05 ` [PATCH 09/10] drivers/i2c/busses/scx200_acb.c: " Heiner Kallweit
2023-11-18 18:05 ` [PATCH 10/10] drivers/i2c/busses/i2c-ali1563.c: " Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19d86ace-a0ea-41d4-82d7-e77ef79e58f7@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox