Re: [PATCH] i2c: Use separate MODULE_AUTHOR() statements for multiple authors

[Jarkko Nikula <jarkko.nikula@linux.intel.com>]

Hi

On 6/11/20 1:02 PM, Jean Delvare wrote:
> Hi Jarrko,
> 
> On Wed, 10 Jun 2020 17:11:42 +0300, Jarkko Nikula wrote:
>> Modules with multiple authors should use multiple MODULE_AUTHOR()
>> statements. Split the i2c modules with multiple authors to use multiple
>> MODULE_AUTHOR() statements.
> 
> Out of curiosity, is this documented anywhere, and what is the
> rationale? FWIW, this change slightly increases the binary size of the
> modules.
> 
I randomly spotted it in i2c-i801.c and started wonder since typically 
I've seen multiple MODULE_AUTHOR() lines. Only mention about it I 
quickly found was in include/linux/module.h:

/*
  * Author(s), use "Name <email>" or just "Name", for multiple
  * authors use multiple MODULE_AUTHOR() statements/lines.
  */
#define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)

> However I see multi-author MODULE_AUTHOR() statements left in
> i2c-nomadik.c, i2c-sirf.c and i2c-viapro.c, any reason why these are
> not included in your patch?
> 
My blind eye :-)

Will include these to 2nd version.

Jarkko